Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNM: testing PR #399 with csi-tests + GroupController support #426

Closed
wants to merge 9 commits into from
Closed

DNM: testing PR #399 with csi-tests + GroupController support #426

wants to merge 9 commits into from

Conversation

nixpanic
Copy link
Member

What type of PR is this?

/kind failing-test
/hold

What this PR does / why we need it:

Testing PR #399 with kubernetes-csi/csi-test#467. This PR only adds a reference to the repository and branch that is used to add GroupController support to the csi-test.

Which issue(s) this PR fixes:

This PR will be closed when #399 is merged.

Special notes for your reviewer:

Please review the other related PRs instead 🤝

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 19, 2023
@k8s-ci-robot k8s-ci-robot requested review from ggriffiths and pohly June 19, 2023 07:30
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 19, 2023
@nixpanic
Copy link
Member Author

/test all

@nixpanic nixpanic mentioned this pull request Jun 19, 2023
Merged
@nixpanic nixpanic force-pushed the csi-test/GroupControllerServer branch from 0993f98 to 8a2301b Compare June 20, 2023 11:19
@nixpanic
Copy link
Member Author

/test all

Now using csi-test:master, after kubernetes-csi/csi-test#467 was merged.

ggriffiths
ggriffiths suggested changes Jun 30, 2023
View reviewed changes
Copy link
Member

@ggriffiths ggriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting to remove from my queue. Feel free to request if help is needed!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nixpanic
Once this PR has been reviewed and has the lgtm label, please assign pohly for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nixpanic nixpanic force-pushed the csi-test/GroupControllerServer branch from 8a2301b to df9dc57 Compare August 7, 2023 09:27
@nixpanic
Copy link
Member Author

/test all

@nixpanic
Copy link
Member Author

/woof

@k8s-ci-robot
Copy link
Contributor

@nixpanic: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nixpanic and others added 9 commits November 23, 2023 14:33
@nixpanic nixpanic force-pushed the csi-test/GroupControllerServer branch from df9dc57 to 2cc0967 Compare November 23, 2023 13:39
@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 23, 2023
@nixpanic
Copy link
Member Author

/test all

@nixpanic
Copy link
Member Author

With the new release of csi-tests, there is no need to run the tests with the master branch anymore.

@nixpanic nixpanic closed this Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggriffiths ggriffiths ggriffiths requested changes

@pohly pohly Awaiting requested review from pohly

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nixpanic @k8s-ci-robot @ggriffiths @leonardoce