storage capacity e2e test by pohly · Pull Request #265 · kubernetes-csi/csi-driver-host-path

pohly · 2021-03-24T16:47:16Z

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

This enables testing CSIStorageCapacity publishing if kubernetes/kubernetes#100537 gets merged.

Does this PR introduce a user-facing change?:

Testing of CSIStorageCapacity publishing with https://github.com/kubernetes/kubernetes/pull/100537 is enabled.

pohly · 2021-03-24T16:48:12Z

/hold

Let's first merge kubernetes/kubernetes#100537. The test-driver.yaml changes cause no harm without it, but also don't make much sense.

verult · 2021-03-24T17:18:12Z

/assign

verult · 2021-03-25T01:58:10Z

    persistence: true
    singleNodeVolume: true
    topology: true
+    capacity: true


If this is always replaced during deployment, I recommend having something like capacity: <to_be_filled> # an explanation instead.

I was also using the file directly when invoking tests manually, so a valid value is more useful. But a comment makes sense - added

verult · 2021-03-25T01:58:51Z

    singleNodeVolume: true
    topology: true
+    capacity: true
+    CSILocalStorage: true


Keeping a comment here as a reminder to remove this

verult · 2021-03-25T01:59:57Z

-else
+if (kubectl get csistoragecapacities.${csistoragecapacities_api}.storage.k8s.io 2>&1 || true) | grep -q "the server doesn't have a resource type"; then
    have_csistoragecapacity=false
+else


nit: print the kubectl output in the else clause, in case the error message changes in the future in which case printing it makes it easier to spot the problem

Added, with truncation in case that there is a long list of objects. I also added printing of the expected API version. It now looks like this:

rolebinding.rbac.authorization.k8s.io/csi-provisioner-role-cfg unchanged csistoragecapacities.v1alpha1.storage.k8s.io: Warning: storage.k8s.io/v1alpha1 CSIStorageCapacity is deprecated in v1.21+, unavailable in v1.24+; use storage.k8s.io/v1beta1 CSIStorageCapacity NAME CREATED AT csisc-665c6 2021-03-24T14:20:03Z csisc-972hh 2021-03-24T15:56:18Z ... deploying with CSIStorageCapacity v1alpha1: true deploying hostpath components

Or with CSI_PROVISIONER_TAG=canary on a fresh cluster:

rolebinding.rbac.authorization.k8s.io/csi-provisioner-role-cfg created csistoragecapacities.v1beta1.storage.k8s.io: No resources found in default namespace. deploying with CSIStorageCapacity v1beta1: true

I moved this fix into a separate PR: #266

pohly · 2021-03-26T15:52:04Z

/hold cancel

verult · 2021-03-29T20:43:03Z

LGTM, will add label after rebase

When using distributed provisioning, topology tests make sense because the driver properly supports topology. CSIStorageCapacity tests are possible if the cluster has the right API.

pohly · 2021-03-30T07:55:20Z

@verult rebased, please LGTM.

verult · 2021-03-30T19:04:55Z

/lgtm

verult · 2021-03-30T19:05:47Z

/assign @msau42
for approval

msau42 · 2021-04-07T01:26:21Z

/approve

pohly · 2021-04-07T08:06:01Z

/approve

k8s-ci-robot · 2021-04-07T08:06:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [msau42,pohly]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

734c2b95 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch f95c855b Merge pull request kubernetes-csi#262 from huww98/golang-toolchain 3c8d966f Treat main branch as equivalent to master branch e31de525 Merge pull request kubernetes-csi#261 from huww98/golang fd153a9e Bump golang to 1.23.1 a8b3d050 pull-test.sh: fix "git subtree pull" errors 6b05f0fc use new GOTOOLCHAIN env to manage go version 227577e Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection e1ceee2 Always enable race detection while running tests 988496a Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c6 chore: bump to Go 1.22.5 69bd71e chore: add CSI_PROW_SIDECAR_E2E_PATH f40f0cc Merge pull request kubernetes-csi#256 from solumath/master cfa9210 Instruction update 379a1bb Merge pull request kubernetes-csi#255 from humblec/sidecar-md a5667bb fix typo in sidecar release process git-subtree-dir: release-tools git-subtree-split: 734c2b950c4b31f64b63052c64ffa5929d1c9b97

98f23071 Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version e9d8712d Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root faf79ff6 Remove --kube-root deprecated kind argument 734c2b95 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch f95c855b Merge pull request kubernetes-csi#262 from huww98/golang-toolchain 3c8d966f Treat main branch as equivalent to master branch e31de525 Merge pull request kubernetes-csi#261 from huww98/golang fd153a9e Bump golang to 1.23.1 a8b3d050 pull-test.sh: fix "git subtree pull" errors 6b05f0fc use new GOTOOLCHAIN env to manage go version 18b6ac6d chore: update CSI driver version to 1.15 227577e Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection e1ceee2 Always enable race detection while running tests 988496a Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c6 chore: bump to Go 1.22.5 69bd71e chore: add CSI_PROW_SIDECAR_E2E_PATH f40f0cc Merge pull request kubernetes-csi#256 from solumath/master cfa9210 Instruction update 379a1bb Merge pull request kubernetes-csi#255 from humblec/sidecar-md a5667bb fix typo in sidecar release process git-subtree-dir: release-tools git-subtree-split: 98f23071d946dd3de3188a7e1f84679067003162

406a79ac Merge pull request kubernetes-csi#267 from huww98/gomodcache 9cec273d Set GOMODCACHE to avoid re-download toolchain 98f23071 Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version e9d8712d Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root faf79ff6 Remove --kube-root deprecated kind argument 734c2b95 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch f95c855b Merge pull request kubernetes-csi#262 from huww98/golang-toolchain 3c8d966f Treat main branch as equivalent to master branch e31de525 Merge pull request kubernetes-csi#261 from huww98/golang fd153a9e Bump golang to 1.23.1 a8b3d050 pull-test.sh: fix "git subtree pull" errors 6b05f0fc use new GOTOOLCHAIN env to manage go version 18b6ac6d chore: update CSI driver version to 1.15 227577e Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection e1ceee2 Always enable race detection while running tests 988496a Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c6 chore: bump to Go 1.22.5 69bd71e chore: add CSI_PROW_SIDECAR_E2E_PATH f40f0cc Merge pull request kubernetes-csi#256 from solumath/master cfa9210 Instruction update 379a1bb Merge pull request kubernetes-csi#255 from humblec/sidecar-md a5667bb fix typo in sidecar release process git-subtree-dir: release-tools git-subtree-split: 406a79acf021b5564108afebeea7d0ed44648d3f

04965932 Merge pull request kubernetes-csi#268 from huww98/cloudbuild 119aee1f Merge pull request kubernetes-csi#266 from jsafrane/bump-sanity-5.3.1 0ae5e52d Update cloudbuild image with go 1.21+ 406a79ac Merge pull request kubernetes-csi#267 from huww98/gomodcache 9cec273d Set GOMODCACHE to avoid re-download toolchain 98f23071 Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version e9d8712d Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root faf79ff6 Remove --kube-root deprecated kind argument 734c2b95 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch 43bde065 Bump csi-sanity to 5.3.1 f95c855b Merge pull request kubernetes-csi#262 from huww98/golang-toolchain 3c8d966f Treat main branch as equivalent to master branch e31de525 Merge pull request kubernetes-csi#261 from huww98/golang fd153a9e Bump golang to 1.23.1 a8b3d050 pull-test.sh: fix "git subtree pull" errors 6b05f0fc use new GOTOOLCHAIN env to manage go version 18b6ac6d chore: update CSI driver version to 1.15 227577e Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection e1ceee2 Always enable race detection while running tests 988496a Merge pull request kubernetes-csi#257 from jakobmoellerdev/csi-prow-sidecar-e2e-path 028f8c6 chore: bump to Go 1.22.5 69bd71e chore: add CSI_PROW_SIDECAR_E2E_PATH f40f0cc Merge pull request kubernetes-csi#256 from solumath/master cfa9210 Instruction update 379a1bb Merge pull request kubernetes-csi#255 from humblec/sidecar-md a5667bb fix typo in sidecar release process git-subtree-dir: release-tools git-subtree-split: 04965932661b6e62709dcdbb9c25da528bac2605

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 24, 2021

k8s-ci-robot requested review from msau42 and vladimirvivien March 24, 2021 16:47

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2021

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2021

k8s-ci-robot assigned verult Mar 24, 2021

pohly mentioned this pull request Mar 24, 2021

storage e2e: verify CSIStorageCapacity publishing kubernetes/kubernetes#100537

Merged

verult suggested changes Mar 25, 2021

View reviewed changes

pohly force-pushed the storage-capacity-e2e-test branch from dcc2fed to 2291e3a Compare March 25, 2021 08:39

pohly mentioned this pull request Mar 26, 2021

deploy: fix CSIStorageCapacity check on alpha clusters #266

Merged

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 26, 2021

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 26, 2021

deploy: enable topology and capacity tests for distributed deployment

7955f68

When using distributed provisioning, topology tests make sense because the driver properly supports topology. CSIStorageCapacity tests are possible if the cluster has the right API.

pohly force-pushed the storage-capacity-e2e-test branch from 2291e3a to 7955f68 Compare March 30, 2021 07:54

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 30, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2021

k8s-ci-robot assigned msau42 Mar 30, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021

k8s-ci-robot merged commit 49e5037 into kubernetes-csi:master Apr 7, 2021

rhrmo mentioned this pull request Dec 17, 2024

Update release tools #574

Merged

Conversation

pohly commented Mar 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pohly commented Mar 24, 2021

Uh oh!

verult commented Mar 24, 2021

Uh oh!

verult Mar 25, 2021

Choose a reason for hiding this comment

Uh oh!

pohly Mar 25, 2021

Choose a reason for hiding this comment

Uh oh!

verult Mar 25, 2021

Choose a reason for hiding this comment

Uh oh!

pohly Mar 25, 2021

Choose a reason for hiding this comment

Uh oh!

verult Mar 25, 2021

Choose a reason for hiding this comment

Uh oh!

pohly Mar 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pohly Mar 26, 2021

Choose a reason for hiding this comment

Uh oh!

pohly commented Mar 26, 2021

Uh oh!

verult commented Mar 29, 2021

Uh oh!

pohly commented Mar 30, 2021

Uh oh!

verult commented Mar 30, 2021

Uh oh!

verult commented Mar 30, 2021

Uh oh!

msau42 commented Apr 7, 2021

Uh oh!

pohly commented Apr 7, 2021

Uh oh!

k8s-ci-robot commented Apr 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pohly commented Mar 24, 2021 •

edited

Loading

pohly Mar 25, 2021 •

edited

Loading