Skip to content

Add VolumeContentSource to CreateVolumeResponse#137

Merged
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
Madhu-1:fix-contentSource
Jan 10, 2020
Merged

Add VolumeContentSource to CreateVolumeResponse#137
k8s-ci-robot merged 2 commits intokubernetes-csi:masterfrom
Madhu-1:fix-contentSource

Conversation

@Madhu-1
Copy link
Copy Markdown
Contributor

@Madhu-1 Madhu-1 commented Jan 9, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Add VolumeContentSource to the Volume CreateResponse for the existing volumes.
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Madhu-1 added 2 commits January 9, 2020 17:29
@Madhu-1
Remove comment related to RBD
91759ef 
As host-path driver doesnot deals with RBD volume
remove RBD mentioned in comment.
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@Madhu-1
Add ContentSource to create VolumeResponse
dadaa9d 
Added ContentSource to the create VolumeResponse
for existing volumes

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 9, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 9, 2020

Welcome @Madhu-1!

It looks like this is your first PR to kubernetes-csi/csi-driver-host-path 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-host-path has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 9, 2020

Hi @Madhu-1. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2020
@Madhu-1
Copy link
Copy Markdown
Contributor Author

Madhu-1 commented Jan 9, 2020

/assign @msau42
/assign @jsafrane

@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Jan 9, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2020
@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Jan 10, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, Madhu-1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2020
@jsafrane
Copy link
Copy Markdown
Contributor

jsafrane commented Jan 10, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit a5e89c3 into kubernetes-csi:master Jan 10, 2020
pohly added a commit to pohly/csi-driver-host-path that referenced this pull request Mar 18, 2021
@pohly
Squashed 'release-tools/' changes from 1748b16..95eac33
5d6ce51 
95eac33 Merge pull request kubernetes-csi#137 from pohly/fix-go-version-check
437e431 verify-go-version.sh: fix check after removal of travis.yml

git-subtree-dir: release-tools
git-subtree-split: 95eac33
@Madhu-1 Madhu-1 mentioned this pull request Apr 3, 2024
Closed
9 tasks
TerryHowe pushed a commit to TerryHowe/csi-driver-host-path that referenced this pull request Oct 17, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#137 from pohly/fix-go-version-check
95eac33 
verify-go-version.sh: fix check after removal of travis.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@jsafrane jsafrane

@msau42 msau42

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Madhu-1 @k8s-ci-robot @jsafrane @msau42