Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

feat: merging kubeconfig files #94

Merged

Conversation

tomplus
Copy link
Member

@tomplus tomplus commented Oct 19, 2018

I'm trying to add support for multiple kubeconfig file. I prepared an additional class which merges configs and produces ConfigNode which can be passed directly to KubeConfigLoader. KubeConfigLoader and other public methods are backward compatible. I had to extend the ConfigNode by adding path to source kubeconfig too, because paths to certificates are relative.

Please let me know what you think.

Related issue: #62

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 19, 2018
@codecov-io
Copy link

codecov-io commented Oct 19, 2018

Codecov Report

Merging #94 into master will increase coverage by 0.59%.
The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   92.04%   92.64%   +0.59%     
==========================================
  Files          13       13              
  Lines        1182     1264      +82     
==========================================
+ Hits         1088     1171      +83     
+ Misses         94       93       -1
Impacted Files Coverage Δ
config/kube_config_test.py 94.82% <100%> (+0.4%) ⬆️
config/kube_config.py 86.74% <95.52%> (+2.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 949c39e...8d4c760. Read the comment docs.

@tomplus tomplus changed the title feat: merging kubeconfig files (WIP) feat: merging kubeconfig files Oct 28, 2018
@tomplus tomplus force-pushed the feat/merge-kubeconfigs branch 6 times, most recently from d7f8138 to fea09d4 Compare November 11, 2018 22:32
@tomplus
Copy link
Member Author

tomplus commented Nov 11, 2018

@roycaihw could you take a look?

@roycaihw roycaihw self-assigned this Nov 15, 2018
@tomplus
Copy link
Member Author

tomplus commented Jan 12, 2019

@roycaihw Have you had time to look into this?

config/kube_config.py Show resolved Hide resolved
config/kube_config_test.py Outdated Show resolved Hide resolved
config/kube_config.py Show resolved Hide resolved
@roycaihw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, tomplus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5c03b3b into kubernetes-client:master Mar 18, 2019
@tomplus
Copy link
Member Author

tomplus commented Mar 18, 2019

@roycaihw Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants