Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

add support for server side apply #254

Merged
merged 1 commit into from
Oct 11, 2021
Merged

add support for server side apply #254

merged 1 commit into from
Oct 11, 2021

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Sep 16, 2021 •
edited by roycaihw
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

add support for server side apply feature for dynamic client

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add support for server side apply feature for dynamic client

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 16, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 16, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @abikouo!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 16, 2021
@abikouo
Copy link
Contributor Author

abikouo commented Sep 16, 2021

@fabianvf

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2021
@roycaihw
Copy link
Member

/assign @fabianvf @roycaihw

fabianvf
fabianvf reviewed Sep 27, 2021
View reviewed changes
dynamic/client.py Outdated Show resolved Hide resolved
fabianvf
fabianvf reviewed Sep 28, 2021
View reviewed changes
dynamic/client.py Outdated Show resolved Hide resolved
@abikouo abikouo mentioned this pull request Oct 1, 2021
Closed
fabianvf
fabianvf approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@fabianvf fabianvf left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

May need a release note though (that can be done in the PR text, doesn't require a commit or anything)

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 7, 2021
@roycaihw
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abikouo, fabianvf, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 21f1d7f into kubernetes-client:master Oct 11, 2021
@fabianvf fabianvf mentioned this pull request Nov 19, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabianvf fabianvf fabianvf approved these changes

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@fabianvf fabianvf

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abikouo @k8s-ci-robot @roycaihw @fabianvf