Support false values in configuration file

[ganchurin]

The purpose of this changes is to fix the issue: kubernetes-client/python#954

[k8s-ci-robot]

Welcome @ganchurin!

It looks like this is your first PR to kubernetes-client/python-base 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python-base has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[codecov-io]

Codecov Report

Merging #161 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   93.56%   93.56%           
=======================================
  Files          13       13           
  Lines        1384     1384           
=======================================
  Hits         1295     1295           
  Misses         89       89

Impacted Files	Coverage Δ
config/kube_config_test.py	95.19% <ø> (ø)	⬆️
config/kube_config.py	88.15% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5092d96...03e347a. Read the comment docs.

[ganchurin]

/assign @yliaog

[roycaihw]

s/False/"false" in consistent with the test case below

[ganchurin]

@roycaihw Thanks for the suggestion! I've just tried to replace False with "false" and faced an issue - the unit test fails. I think the cause is in how "insecure-skip-tls-verify" property is handled in kube_config.py (https://github.com/kubernetes-client/python-base/blob/master/config/kube_config.py#L443). The code by the link casts a string to a boolean. Both "true" and "false" are casted to True. What do you think if I replace "true" with True in the older test?

[roycaihw]

"true" and "false" are the original values in kubeconfig yaml files (e.g. insecure-skip-tls-verify: false). The test cases are testing values stored in the KubeConfigLoader object.

Could you verify what's the behavior in the yaml loader? Does it load "false" into a boolean False, or does it keep the string value "false"?

[ganchurin]

I verified the behavior on the configuration file which has the following lines:

clusters:
- cluster:
    insecure-skip-tls-verify: false

The following code snippet was used for the verification:

import yaml

with open(<PATH_TO_CONFIG>) as f:
    config = yaml.safe_load(f)
    print config (**breakpoint was set here**)

Debug showed the following value for the property:
'insecure-skip-tls-verify' (4523129968) = {bool} False

[roycaihw]

Thanks. Let's use True and False in the test cases then

[roycaihw]

/lgtm
/approve

Thanks @ganchurin!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ganchurin, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [roycaihw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ganchurin]

/retest

[k8s-ci-robot]

@ganchurin: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ganchurin]

@roycaihw Could you please help me a bit? Some tests have failed after my update to the branch. I'm not sure that they relate to the scope of work. And I can't restart test run. Thanks in advance!

[micw523]

/ok-to-test
???? What’s happening here? I didn’t remember we required ok to test

[micw523]

The Travis CI is showing a ton of 404 and other errors. Try looking at the log - it is available.

[ganchurin]

/retest

[ganchurin]

@micw523 Thank you! I've taken a look.

I've noticed that the same tests fail in the latest build of "kubernetes-client/python" repository: https://travis-ci.org/kubernetes-client/python/builds/587650221

As for my pull request, previously the pull request had passed successfully. The single difference between successful and failed attempts is one line in unit tests that works fine for me locally. Thus I tend thinking that the issue is in "kubernetes-client/python" repository.

[micw523]

The most recent build in k8s-python passed; I'm restarting your build to see if the test fail is a flake.

[ganchurin]

@micw523 Sorry if I'm wrong - I was looking for builds here: https://travis-ci.org/kubernetes-client/python/builds. And the latest build is red.

[roycaihw]

Test failure tracked in kubernetes-client/python#963. Let's fix the CI first and then merge this PR