-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add openapi-generator v5.x support to python client #208
add openapi-generator v5.x support to python client #208
Conversation
Welcome @itaru2622! |
/assign @yliaog |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: itaru2622, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -19,6 +19,7 @@ | |||
<configuration> | |||
<inputSpec>${generator.spec.path}</inputSpec> | |||
<language>python</language> | |||
<generatorName>python</generatorName> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it breaks the existing client generation:
org.apache.maven.plugin.MojoExecutionException: Illegal configuration: 'language' and 'generatorName' can not be set both, remove 'language' from your configuration
...
[ERROR] Failed to execute goal org.openapitools:openapi-generator-maven-plugin:4.3.0:generate (default) on project client-python: Code generation failed. See above for the full exception. -> [Help 1]
related to #207,
this PR makes python client ready to openapi-generator v5.x.