Skip to content

Clean up NuGet workflow #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jan 23, 2022
Merged

Clean up NuGet workflow #768

merged 25 commits into from
Jan 23, 2022

Conversation

MaxHorstmann
Copy link
Contributor

@MaxHorstmann MaxHorstmann commented Jan 21, 2022 •
edited
Loading

Follow-up to #759: confirmed that GH runner now has GitHub CLI version 2.4.0, so this step can now be cleaned up.

Confirmed in fork that it works.

MaxHorstmann and others added 20 commits January 8, 2022 17:50
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MaxHorstmann
To complete the pull request process, please assign brendandburns after the PR has been reviewed.
You can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 21, 2022
@MaxHorstmann MaxHorstmann marked this pull request as draft January 21, 2022 19:32
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2022
@MaxHorstmann
Revert "disable push"
4bc2b21 
This reverts commit 143978d.
@MaxHorstmann
Revert "skip tests"
699e464 
This reverts commit 4362d21.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 21, 2022
@MaxHorstmann MaxHorstmann marked this pull request as ready for review January 21, 2022 21:06
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2022
@MaxHorstmann
Copy link
Contributor Author

pinging @brendandburns @krabhishek8260 for review

@MaxHorstmann
Copy link
Contributor Author

/assign @brendandburns

@tg123
Copy link
Member

tg123 commented Jan 23, 2022

/LGTM

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2022
@tg123 tg123 merged commit 19d750c into kubernetes-client:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

Assignees

@tg123 tg123

@brendandburns brendandburns

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaxHorstmann @k8s-ci-robot @tg123 @brendandburns