Skip to content

way to disable http2 #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
k8s-ci-robot merged 2 commits into from
Dec 13, 2022
Merged

way to disable http2 #1120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b75b935
way to disable http2
tg123 Dec 11, 2022
9800649
no option for netstand2.0
tg123 Dec 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/KubernetesClient/Kubernetes.ConfigInit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ public Kubernetes(KubernetesClientConfiguration config, params DelegatingHandler
CreateHttpClient(handlers, config);
InitializeFromConfig(config);
HttpClientTimeout = config.HttpClientTimeout;
#if NETSTANDARD2_1_OR_GREATER || NET5_0_OR_GREATER
DisableHttp2 = config.DisableHttp2;
#endif
}

private void ValidateConfig(KubernetesClientConfiguration config)
Expand Down
9 changes: 8 additions & 1 deletion src/KubernetesClient/Kubernetes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ public Uri BaseUri
private HttpClientHandler HttpClientHandler { get; set; }
#endif

#if NETSTANDARD2_1_OR_GREATER || NET5_0_OR_GREATER
private bool DisableHttp2 { get; set; }
#endif

/// <summary>
/// Initializes client properties.
/// </summary>
Expand Down Expand Up @@ -108,7 +112,10 @@ protected override Task<HttpResponseMessage> SendRequest<T>(string relativeUri,
};

#if NETSTANDARD2_1_OR_GREATER || NET5_0_OR_GREATER
httpRequest.Version = HttpVersion.Version20;
if (!DisableHttp2)
{
httpRequest.Version = HttpVersion.Version20;
}
#endif
// Set Headers
if (customHeaders != null)
Expand Down
5 changes: 5 additions & 0 deletions src/KubernetesClient/KubernetesClientConfiguration.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,5 +103,10 @@ public partial class KubernetesClientConfiguration
#else
public Action<HttpClientHandler> FirstMessageHandlerSetup { get; set; }
#endif

/// <summary>
/// Do not use http2 even it is available
/// </summary>
public bool DisableHttp2 { get; set; } = false;
}
}