`Yaml.LoadFromString` (and others) are broken due to `namespace` keyword.

[twitchax]

V1ObjectMetadata defines the namespace property as follows.

[JsonProperty(PropertyName = "namespace")]
public string NamespaceProperty { get; set; }

This is likely because namespace is a reserved keyword in C#. However, YamlDotNet does not respect the JsonProperty attribute, so these deserializers fail when they come across namespace in the Yaml.

The best fix would be to either use an attribute that YamlDotNet understands, or to rename this property to Namespace, since C# doesn't care if the N is capitalized. Lastly, to avoid confusion, this property to could be marked with the @.

[twitchax]

ReadOnlyProperty on V1VolumeMount also suffers from this issue.

[itowlson]

Yes, the AutoRest generator which converts the k8s Swagger to C# code special-cases words that are reserved in C#, such as namespace or readonly. I don't think we can change this without changing AutoRest, and of course it would be breaking change for consumers of the client. I've reproduced and got a failing unit test for it, will see if I can puzzle out a fix without changing the existing library surface. Thanks!

[twitchax]

Interestingly, I use to work with the primary AutoRest maintainer, @fearthecowboy.

@fearthecowboy, is there a graceful way to instruct AutoRest to not rename these properties? In this case, the property names are PascalCased, so there will not be any clash in .NET code.

[fearthecowboy]

Yeah, the generator is a bit... overzealous when attempting to avoid collisions and keywords.

If you are using a configuration file, you can stick in a section :

# rename properties back to what we want them to be.
``` yaml $(csharp)
directive: 
  - reason: Tweaking the generated code.
    from: source-file-csharp
    where: $
    transform:  return $.replace(/NamespaceProperty/g, 'Namespace').replace(/ReadOnlyProperty/g,'ReadOnly');
```

[twitchax]

Nice! Thanks for the info, @fearthecowboy!

@itowlson, I see you already opened a PR, but this method might be better in the long run.

[itowlson]

Well, Namespace and ReadOnly are also keywords in Visual Basic, which is case-insensitive. So I'm not sure coercing them to the undecorated form is desirable... though other languages will also have escape clauses similar to C#'s @namespace...

But yeah solving it at codegen would be nice. @fearthecowboy, can we configure AutoRest to emit YamlMemberAttribute as well as JsonPropertyAttribute?

[fearthecowboy]

With the from: source-file-csharp, the transform: directive is basically allowing you to edit the c# files before they are saved to disk.

It's just doing a javascript call on the provided code, so you can do some replaces w/regex to tweak what you want, and get consistent results from the generator when you update the swagger file.

You can even do pretty complex things -- example -- so it wouldn't be much effort to make one that creates YamlMemberAttributes too.

[itowlson]

Thanks Garrett - this may be a more direct method than my type inspector fix - will take a look.

[RohanNagar]

Are there any updates on this fix?

[itowlson]

My bad, Rohan. I went down a rabbit hole with the AutoRest config fix but got lost. I think we should go with the existing fix and see if we can switch to a codegen solution later.