-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 2 useful PRs and other changes from OpenAPITools/openapi-generator repo #7
Conversation
1. Support SSL client authentication for the c client (#5719) 2. Fix base64 decode funtion (#5642)
This change looks good to me. Is this a manual patch? Or did you re-run code generation? |
Yes, this is a manual patch. We do not need re-run code generation because there is no difference between manual patch and code generation for the files For others model or api files generated by openapi-generator, there is also no important changes. But I can re-run code generation too, it does not need big effort. which solution do you prefer ? |
I'd prefer that we re-run the code generation, I think it is a good practice to never hand-edit the generated files. Thanks! |
Sure. I will do it. And |
The code generation is re-run (both build and examples test successfully) and new code change is pushed here. |
/lgtm Thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, ityuhui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
To implement the configuration for kubernetes-client/c, merge 2 PRs from OpenAPITools/openapi-generator repo:
Support SSL client authentication for the c client (#5719)
[C][Client] Support SSL client authentication for the c client OpenAPITools/openapi-generator#5719
Fix base64 decode funtion (#5642)
[C] fix decode function OpenAPITools/openapi-generator#5642
/cc @brendandburns