feature: Add control flag for static compile

[Jeansen]

Similar to https://github.com/yaml/libyaml, this PR adds a flag BUILD_SHARED_LIBS to build a statically linked library of kubernetes-client.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Jeansen / name: Marcel (634f61b, 625bc6c)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jeansen
Once this PR has been reviewed and has the lgtm label, please assign brendandburns for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @Jeansen!

It looks like this is your first PR to kubernetes-client/c 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/c has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[ityuhui]

Hello @Jeansen

Can you set shared compile by default ?

Change -DBUILD_SHARED_LIBS to -DBUILD_STATIC_LIBS

[ityuhui]

Actually kubernetes/CMakeLists.txt is generated from https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/C-libcurl/CMakeLists.txt.mustache

Can you please submit a PR to https://github.com/openAPITools/openapi-generator/ ?

[ityuhui]

What's the purpse of "-DBUILD_TESTING=OFF" ?

[Jeansen]

Oh..that was a mistake. No purpose ... copy / paste error.

[Jeansen]

Actually kubernetes/CMakeLists.txt is generated from https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/C-libcurl/CMakeLists.txt.mustache

Can you please submit a PR to https://github.com/openAPITools/openapi-generator/ ?

OK, I'll do that ;-)

[Jeansen]

OpenAPITools/openapi-generator#21635

And I followed your suggestion to change -DBUILD_SHARED_LIBS to -DBUILD_STATIC_LIBS.

I admit, it was late and I overlooked some details. Thank you for the review!

Since this PR will be then in OpenAPITools, I'll close this one.

[Jeansen]

@ityuhui My changes have been merged in openapi-generator and will be included in the upcoming release. Please drop me a line when this release is part of this project. I'd be happy to update the docs in this repo to reflect the new changes.

[ityuhui]

Sure. I think @brendandburns is regenerating the client to include all recent CRs from openapi-generator.
After that, I'll request you to submit your CR for documentation.
Thanks for your contribution!

[ityuhui]

Hi @Jeansen

The latest changes from openapi-generator have been merged here.
You can now open your pull request for the documentation.

[Jeansen]

Done ;-)