Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Cypress to v10 #4929

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Migrate Cypress to v10 #4929

merged 1 commit into from
Sep 15, 2022

Conversation

Waseem826
Copy link
Contributor

@Waseem826 Waseem826 commented Sep 5, 2022 •
edited
Loading

What this PR does / why we need it:
Migrate cypress to v10

Which issue(s) this PR fixes:

Fixes #4548

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 5, 2022
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Waseem826
Copy link
Contributor Author

/test all

@kubermatic-bot kubermatic-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 5, 2022
@Waseem826
Copy link
Contributor Author

/test all

@codecov
Copy link

codecov bot commented Sep 5, 2022 •
edited
Loading

Codecov Report

Merging #4929 (21633bd) into master (4679131) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4929   +/-   ##
=======================================
  Coverage   48.75%   48.75%           
=======================================
  Files         389      389           
  Lines       14734    14734           
  Branches     2683     2683           
=======================================
  Hits         7184     7184           
  Misses       7127     7127           
  Partials      423      423

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4679131...21633bd. Read the comment docs.

@Waseem826
Copy link
Contributor Author

/test pre-dashboard-test-e2e

@Waseem826
Copy link
Contributor Author

/test pre-dashboard-test-e2e-ce

@Waseem826
Copy link
Contributor Author

/test pre-dashboard-test-e2e

@Waseem826
Copy link
Contributor Author

/hold
This PR is blocked until cypress-io/cypress#23637 is merged and a new version of Cypress is available.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2022
@Waseem826 Waseem826 force-pushed the 4548-switch-to-cypress-v10 branch 2 times, most recently from a19ce90 to 37b4c2b Compare September 8, 2022 09:48
@Waseem826
Copy link
Contributor Author

/test pre-dashboard-test-e2e

@Waseem826
Copy link
Contributor Author

/test all

@Waseem826 Waseem826 marked this pull request as ready for review September 14, 2022 12:35
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2022
@kubermatic-bot
Copy link
Contributor

@Waseem826: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-dashboard-test-full-e2e-ce 21633bd link false /test pre-dashboard-test-full-e2e-ce
pre-dashboard-test-full-e2e 21633bd link false /test pre-dashboard-test-full-e2e

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Waseem826
Copy link
Contributor Author

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2022
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1d8eefc561dbd154a8df3d98366641dc2df77f9d

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, Waseem826

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Waseem826,ahmedwaleedmalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 7199928 into kubermatic:master Sep 15, 2022
@Waseem826 Waseem826 deleted the 4548-switch-to-cypress-v10 branch September 15, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to Cypress v10
3 participants
@Waseem826 @kubermatic-bot @ahmedwaleedmalik