Skip to content

Expose --drain-pod-selector#43

Merged
ckotzbauer merged 2 commits intokubereboot:feature/release-1.14.0from
docbobo:main
Aug 19, 2023
Merged

Expose --drain-pod-selector#43
ckotzbauer merged 2 commits intokubereboot:feature/release-1.14.0from
docbobo:main

Conversation

@docbobo
Copy link
Copy Markdown
Contributor

@docbobo docbobo commented Jun 30, 2023

Exposes the --drain-pod-selector cli parameter introduced with kureboot/kured#788 through the helm chart

Signed-off-by: Boris Pruessmann <boris@pruessmann.org>
Copy link
Copy Markdown
Member

@ckotzbauer ckotzbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :)
Delay the merge until there's a kured release.

@ckotzbauer ckotzbauer added this to the 1.14.0 milestone Aug 12, 2023
@ckotzbauer ckotzbauer changed the base branch from main to feature/release-1.14.0 August 19, 2023 08:54
Signed-off-by: Christian Kotzbauer <git@ckotzbauer.de>
@ckotzbauer ckotzbauer merged commit 544f822 into kubereboot:feature/release-1.14.0 Aug 19, 2023
ckotzbauer added a commit that referenced this pull request Aug 21, 2023
* expose --drain-pod-selector (#43)

Signed-off-by: Boris Pruessmann <boris@pruessmann.org>
Signed-off-by: Christian Kotzbauer <git@ckotzbauer.de>
Co-authored-by: Christian Kotzbauer <git@ckotzbauer.de>

* Adds new flag --metrics-host to chart (#50)

kubereboot/kured#811

Signed-off-by: Nathan Kinkade <kinkade@measurementlab.net>
Signed-off-by: Christian Kotzbauer <git@ckotzbauer.de>
Co-authored-by: Christian Kotzbauer <git@ckotzbauer.de>

* feat: changes for 1.14.0

Signed-off-by: Christian Kotzbauer <git@ckotzbauer.de>

---------

Signed-off-by: Boris Pruessmann <boris@pruessmann.org>
Signed-off-by: Christian Kotzbauer <git@ckotzbauer.de>
Signed-off-by: Nathan Kinkade <kinkade@measurementlab.net>
Co-authored-by: Boris Prüßmann <docbobo@users.noreply.github.com>
Co-authored-by: nkinkade <nathan@kinkade.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants