Remove kubevirt/pkg/controller dependency #4933
Open
+455
−86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What type of this PR
By importing
kubevirt.io/kubevirt
, KubeOVN also has to import and deal with an incredible amount of legacy cruft. Compare tokubevirt.io/api
, the Go dependencies of the main kubevirt module are not so very much up-to-date.KubeOVN only uses a single struct from the kubevirt codebase, and of that struct just very little. I propose that it is cheaper and in the long-term more maintainable to copy-paste the required code into this repository. This gets rid of the heavy dependency and quite a few
replace
directives. This in turn helps other projects that import KubeOVN into their codebase.Since both projects are Apache Licensed, I would consider this an okay-ish hack with more upsides than downsides.