Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed sparkJobNamespaces to spark.JobNamespaces #3924

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vikas-saxena02
Copy link
Contributor

@vikas-saxena02 vikas-saxena02 commented Nov 15, 2024

This PR is to correct the typo in documentation where the property for spark-operator pod to monitor multiple namespaces was incorrectly specified in documentation as sparkjoNamespaces insted of spark.jobNamespaces

closes kubeflow/spark-operator#2103

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yuchaoran2011 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vikas-saxena02 vikas-saxena02 force-pushed the fixing_sparkOperator_multinamespace_documantation branch from 0b34bc0 to 97304b7 Compare November 15, 2024 12:51
@vikas-saxena02
Copy link
Contributor Author

closes kubeflow/spark-operator#2103

@vikas-saxena02
Copy link
Contributor Author

@vara-bonthu @jacobsalway @andreyvelich can someone please review this for me? its just a correction of typo in documentation

@jacobsalway
Copy link
Member

/lgtm

Thanks @vikas-saxena02 for fixing this. I think a few users have reported confusion over this value renaming.

@jacobsalway
Copy link
Member

jacobsalway commented Nov 18, 2024

closes kubeflow/spark-operator#2103

I think you need to add it to the PR description rather than just a comment for Github to automatically close this issue.

@vikas-saxena02
Copy link
Contributor Author

/lgtm

Thanks @vikas-saxena02 for fixing this. I think a few users have reported confusion over this value renaming.

@jacobsalway i think you will need to approve the PR as well

@jacobsalway
Copy link
Member

jacobsalway commented Nov 18, 2024

I'm only a reviewer. You'll need someone on the approves list to approve it - see https://github.com/kubeflow/website/blob/master/content/en/docs/components/spark-operator/OWNERS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Service Account not working different namespace
2 participants