-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed sparkJobNamespaces to spark.JobNamespaces #3924
base: master
Are you sure you want to change the base?
changed sparkJobNamespaces to spark.JobNamespaces #3924
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Vikas Saxena <[email protected]>
0b34bc0
to
97304b7
Compare
closes kubeflow/spark-operator#2103 |
@vara-bonthu @jacobsalway @andreyvelich can someone please review this for me? its just a correction of typo in documentation |
/lgtm Thanks @vikas-saxena02 for fixing this. I think a few users have reported confusion over this value renaming. |
I think you need to add it to the PR description rather than just a comment for Github to automatically close this issue. |
@jacobsalway i think you will need to approve the PR as well |
I'm only a reviewer. You'll need someone on the approves list to approve it - see https://github.com/kubeflow/website/blob/master/content/en/docs/components/spark-operator/OWNERS. |
This PR is to correct the typo in documentation where the property for spark-operator pod to monitor multiple namespaces was incorrectly specified in documentation as
sparkjoNamespaces
insted ofspark.jobNamespaces
closes kubeflow/spark-operator#2103