Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explained the various installation options for Kubeflow Pipelines #1472

Merged
merged 4 commits into from
Dec 21, 2019

Conversation

sarahmaddox
Copy link
Contributor

@sarahmaddox sarahmaddox commented Dec 18, 2019

Fixes #1429


This change is Reviewable

@sarahmaddox sarahmaddox changed the title WIP Explain the various installation options for Kubeflow Pipelines Explained the various installation options for Kubeflow Pipelines Dec 19, 2019
@sarahmaddox
Copy link
Contributor Author

This PR is ready for review. Applying a hold to allow for multiple reviewers.

/hold

@sarahmaddox
Copy link
Contributor Author

/assign @Bobgy

@joeliedtke
Copy link
Member

/assign @joeliedtke

@joeliedtke
Copy link
Member

/lgtm

Tech writer review LGTM.

@k8s-ci-robot k8s-ci-robot requested a review from IronPan December 20, 2019 05:05
@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 20, 2019
Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The changes looks great. Added one single personal opinion.

@@ -54,6 +54,9 @@
# Replaces Pipelines DSL overview with SDK overview
/docs/pipelines/sdk/dsl-overview/ /docs/pipelines/sdk/sdk-overview/

# Created a new section for pipelines installation.
/docs/pipelines/standalone-deployment-gcp/ /docs/pipelines/installation/standalone-deployment/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR moves the existing doc into a new section, and this code redirects incoming links from the existing doc to the new section.
To test the redirect, try going to this link in the preview of this PR:
https://deploy-preview-1472--competent-brattain-de2d6d.netlify.com/docs/pipelines/standalone-deployment-gcp/


* Kubeflow Pipelines as [part of a full Kubeflow deployment](#full-kubeflow).
* A [standalone](#standalone) Kubeflow Pipelines deployment.
* **Alpha**: Kubeflow Pipelines deployed [from the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we list them in the order of deployment simplicity, i.e. "hosted pipeline", "standalone", "full-kubeflow"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've moved standalone to the top, so the order is now standalone, full, hosted. I think we should leave hosted as the last option, because (a) it's still in alpha, and (b) it's GCP only. Does that sound good to you too?

@sarahmaddox
Copy link
Contributor Author

Thanks all! I've responded to your review comments. The updated preview is available:
https://deploy-preview-1472--competent-brattain-de2d6d.netlify.com/docs/pipelines/installation/overview/

@sarahmaddox
Copy link
Contributor Author

/hold cancel

@sarahmaddox
Copy link
Contributor Author

This is ready to merge, if someone could give it an LGTM.

@joeliedtke
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joeliedtke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 19c3089 into kubeflow:master Dec 21, 2019
@Bobgy
Copy link
Contributor

Bobgy commented Dec 21, 2019

@sarahmaddox Thank you! This is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipelines: Add guide to implications and capabilities of each deployment method
6 participants