-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explained the various installation options for Kubeflow Pipelines #1472
Conversation
This PR is ready for review. Applying a hold to allow for multiple reviewers. /hold |
/assign @Bobgy |
/assign @joeliedtke |
/lgtm Tech writer review LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The changes looks great. Added one single personal opinion.
@@ -54,6 +54,9 @@ | |||
# Replaces Pipelines DSL overview with SDK overview | |||
/docs/pipelines/sdk/dsl-overview/ /docs/pipelines/sdk/sdk-overview/ | |||
|
|||
# Created a new section for pipelines installation. | |||
/docs/pipelines/standalone-deployment-gcp/ /docs/pipelines/installation/standalone-deployment/ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already see a section "https://www.kubeflow.org/docs/pipelines/standalone-deployment-gcp/" on kubeflow website, https://www.kubeflow.org/docs/pipelines/standalone-deployment-gcp/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR moves the existing doc into a new section, and this code redirects incoming links from the existing doc to the new section.
To test the redirect, try going to this link in the preview of this PR:
https://deploy-preview-1472--competent-brattain-de2d6d.netlify.com/docs/pipelines/standalone-deployment-gcp/
|
||
* Kubeflow Pipelines as [part of a full Kubeflow deployment](#full-kubeflow). | ||
* A [standalone](#standalone) Kubeflow Pipelines deployment. | ||
* **Alpha**: Kubeflow Pipelines deployed [from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we list them in the order of deployment simplicity, i.e. "hosted pipeline", "standalone", "full-kubeflow"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've moved standalone to the top, so the order is now standalone, full, hosted. I think we should leave hosted as the last option, because (a) it's still in alpha, and (b) it's GCP only. Does that sound good to you too?
Thanks all! I've responded to your review comments. The updated preview is available: |
/hold cancel |
This is ready to merge, if someone could give it an LGTM. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joeliedtke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sarahmaddox Thank you! This is great. |
Fixes #1429
This change is