Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsMasterRole fix in pytorchjob controller #1969

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

deepanker13
Copy link
Contributor

What this PR does / why we need it:

  1. Correcting the function to check if the pod has a master role or not in case there is only 1 worker in the PyTorch job.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1961

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7285263587

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 42.896%

Totals Coverage Status
Change from base Build 7243429238: 0.01%
Covered Lines: 3756
Relevant Lines: 8756

💛 - Coveralls

@johnugeorge
Copy link
Member

Related: #1961

@johnugeorge
Copy link
Member

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepanker13, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ab5de23 into kubeflow:master Dec 21, 2023
33 checks passed
@terrytangyuan
Copy link
Member

Could we make sure that the PR titles are descriptive before merging next time?

@deepanker13 deepanker13 changed the title isMaster fix IsMasterRole fix in pytorchjob controller Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix label when PyTorchJob has single Worker
4 participants