-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the same reasons for Condition and Event #1854
Conversation
abcd267
to
04d41e1
Compare
|
/assign @johnugeorge @terrytangyuan |
Thanks Yuki |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Currently, jobs use different reasons for Condition and Event even if the situation is the same. (
JobCreated
vsTFJobCreated
)For example, the JobController uses
JobXXX
(XXX is the reason such as Failed), and the pytorchjob-controller usesPyTorchJobXXX
like this:training-operator/pkg/controller.v1/common/job.go
Line 227 in fcdf9a3
training-operator/pkg/controller.v1/pytorch/pytorchjob_controller.go
Line 555 in fcdf9a3
So I modified the reasons for Condition and Event so that the Jobs use consistently the same reason format
${KIND}${REASON}
likePyTorchJobCreated
in the same situation.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: