-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully consolidate tfjob-operator to training-operator #1850
Fully consolidate tfjob-operator to training-operator #1850
Conversation
Signed-off-by: Yuki Iwai <[email protected]>
Pull Request Test Coverage Report for Build 5467682454
💛 - Coveralls |
/assign @johnugeorge |
Thanks for the cleanup. MPIJob is the only one now which has overriden ReconcilePods. This has a different implementation anyways. |
Yes, we should refactor the whole of MPIJob: #1728 |
Thanks @tenzen-y |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I modified the following items to consolidate tfjob-operator to training-operator fully:
GetFrameworkName
function to theController
interface.ReconcilePods
from the tfjob-controller to stop overriding the method of theJobController
.ReconcilePods
of theJobController
to TFJob.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #1727
Checklist: