Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xgb yaml container name should be consistent with xgb job default container name #1794

Merged
merged 1 commit into from
May 10, 2023

Conversation

Crisescode
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Apr 23, 2023

Pull Request Test Coverage Report for Build 4778027694

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 39.338%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 76.79%
Totals Coverage Status
Change from base Build 4659763896: -0.1%
Covered Lines: 2732
Relevant Lines: 6945

💛 - Coveralls

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We must use the xgboost as a default container name.

// XGBoostJobDefaultContainerName is the name of the XGBoostJob container.
XGBoostJobDefaultContainerName = "xgboost"

/lgtm
/assign @terrytangyuan @johnugeorge @gaocegege

@tenzen-y
Copy link
Member

tenzen-y commented May 2, 2023

ping :) > @terrytangyuan @johnugeorge @gaocegege

@johnugeorge
Copy link
Member

Sorry. I missed it

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Crisescode, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0a9d39a into kubeflow:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants