-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set a Running condition when the XGBoostJob is completed and doesn't have a Running condition #1789
Conversation
Pull Request Test Coverage Report for Build 4546766224
💛 - Coveralls |
…have a Running condition Signed-off-by: Yuki Iwai <[email protected]>
659c736
to
1d45349
Compare
@terrytangyuan I addressed your comment. PTAL. |
/lgtm |
/assign @johnugeorge @nagar-ajay |
@tenzen-y: GitHub didn't allow me to assign the following users: nagar-ajay. Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Somehow, I missed this PR Sorry for the delay @tenzen-y /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
I fixed the reconciling error in XGBoost Job.
When XGBoostJob is completed (succeeded or failed) before the controller sets a
Running
condition, XGBoostJob finishes without aRunning
condition.So, I modified the controller so that the controller can set a
Running
condition when the XGboostJob is completed and doesn't have aRunning
condition.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Part-of #1779
Checklist: