Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependabot config script #855

Closed
wants to merge 6 commits into from
Closed

Conversation

davidspek
Copy link

@davidspek davidspek commented Jan 20, 2021

Inspired by kubeflow/pipelines#4682 I created a script that will create a config file for depandabot so that it knows what directories to scan. It will scan the repository for files named *ockerfile*, package*.json, *requirements.txt and go.*. It is setup for dockerfiles and gomod at the moment. As I am not sure if the go.mod and go.sum in ./vendor are relevant, I did not include searching for go.* files in the script. It is trivial to further customize what folders are selected if further customization is needed. It also parses the closest OWNERS file for a given directory and assigns the approvers and adds the reviewers to the PRs it creates.

This is a sibling PR to kubeflow/pipelines#5015, kubeflow/kubeflow#5542, kserve/kserve#1309 and kubeflow/arena#403.

As it stands now, there are about 56 PRs that will be created with this configuration, so it might be advisable to have some form of plan to implement it in stages or be ready to quickly go through lots of the PRs. Another option is to create a target branch for all these PRs so they can be merged into that first rather than master.

For reference, the PRs that will be created can be found here: https://github.com/DavidSpek/testing/pulls

@google-cla google-cla bot added the cla: yes label Jan 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DavidSpek
To complete the pull request process, please assign jlewi after the PR has been reviewed.
You can assign the PR to them by writing /assign @jlewi in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PatrickXYS PatrickXYS requested review from PatrickXYS and Bobgy and removed request for jlewi and Jeffwan January 20, 2021 19:33
Copy link
Member

@PatrickXYS PatrickXYS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, some nit comments:

  1. Have a make command to run create_dependabot.sh
  2. Update README doc to have another section for dependabot functionality and description in this repo

hack/create_dependabot.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@davidspek
Copy link
Author

/assign @PatrickXYS

@davidspek
Copy link
Author

I am holding the PR to have some control over when it gets merged so that the optional test infra doesn't get overloaded if all the repo's were to merge this at the same time.
/hold

@PatrickXYS
Copy link
Member

Can we close the PR in favor of enabling Renovate?

@davidspek
Copy link
Author

I’d say so. I’ll create a PR with an initial Renovate config based on the Pipelines one.

@davidspek davidspek closed this Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants