OpenShift image and fixed bug on running multiple operators/webhooks #343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… an issue with running multiple instances of operator; fixed doc to reflect webhook new default in the chart
liyinan926
reviewed
Dec 14, 2018
liyinan926
reviewed
Dec 17, 2018
yuchaoran2011
commented
Dec 18, 2018
…instead of adding a label to the job namespace
liyinan926
reviewed
Jan 13, 2019
liyinan926
reviewed
Jan 13, 2019
liyinan926
reviewed
Jan 14, 2019
Collaborator
|
Also please fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
restrictedSCC on OpenShift, as also stated in Add an entrypoint to spark-operator for handling non-root users #189. Added a separate DockerfileDockerfile.rhthat builds an OpenShift operator image.MutatingWebhookConfigurationobjects created by the operator did not have a namespace selector, causing multiple webhooks to act on the same Spark pods when each webhook was supposed to only act on pods in the pre-defined namespace. Now with the fix, the chart automatically labels the Spark job namespace properly. (The changes to the chart are coming once this one is merged).This PR was jointly created with my colleague @skonto.