Correct entrypoint.sh for Openshift#2645
Merged
google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom Oct 21, 2025
Merged
Correct entrypoint.sh for Openshift#2645google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom
google-oss-prow[bot] merged 1 commit intokubeflow:masterfrom
Conversation
Reamer
force-pushed
the
entrypoint_openshift
branch
from
9e22e21 to
8aaa814
Compare
Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
Reamer
force-pushed
the
entrypoint_openshift
branch
from
8aaa814 to
63da0b5
Compare
nabuskey
approved these changes
Sep 3, 2025
Contributor
nabuskey
left a comment
nabuskey
left a comment
There was a problem hiding this comment.
LGTM this fixes a bug where user entries were not generated correctly
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This change performs string interpolation during the creation of the temporary file, which is used on Openshift.
There is a parallel pull request that also corrects this behaviour in the official Spark images. apache/spark-docker#90
Proposed changes:
Change Category
Rationale
See issue #2644
Checklist
Additional Notes