Skip to content

Conversation

syntaxsdev
Copy link

What this PR does / why we need it:

Adds Model Registry to KF SDK (as a baseline) by importable extra install.

This is inline with issue #59

Use case:

from kubeflow.trainer import TrainerClient
from kubeflow.model_registry import ModelRegistryClient

We also have original ModelRegistry aliased
This immediately allows users to use surfaced ModelRegistryClient

from kubeflow.model_registry import ModelRegistry

We do not have the mr_openapi added yet because it is not surfaced via MR client, so a separate fix will come later once surfaced into MR, but it is not super urgent since mr_openapi was never surfaced in the first place in the model registry client.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):

Fixes #59

Checklist:

  • Docs included if any changes are user facing

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign electronic-waste for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kramaranya
Copy link
Contributor

Thank you @syntaxsdev! Before we proceed with the implementation, I think we should first discuss which approach would be most efficient and maintainable long-term in the original issue #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Model Registry Client to Kubeflow SDK
2 participants