-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): Upload namespaced pipeline definitions. Part of #4197 #8512
feat(sdk): Upload namespaced pipeline definitions. Part of #4197 #8512
Conversation
Skipping CI for Draft Pull Request. |
sdk/python/requirements.in
Outdated
@@ -22,7 +22,7 @@ kfp-pipeline-spec>=0.1.16,<0.2.0 | |||
# Update the lower version when kfp sdk depends on new apis/fields in | |||
# kfp-server-api. | |||
# Note, please also update ./requirements.in | |||
kfp-server-api>=2.0.0a0,<3.0.0 | |||
kfp-server-api>=2.0.0a7,<3.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JFYI, we're in progress updating APIs for v2, once that is done (ETA: end of the month or early January), the next release would be the first beta.
@elikatsis what is the status of this and the webinterface? |
@juliusvonkohout for this one we're waiting for a new release of the |
@elikatsis is that here not the release you want ? https://github.com/kubeflow/pipelines/releases/tag/2.0.0-beta.0 |
1673b07
to
10bb01b
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @juliusvonkohout, great coincidence 😄 @chensun I've updated and rebased the branch. This should be good to go if everything gets green :) |
@elikatsis: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
wth
There are some breaking changes in |
The breaking changes are from |
@chensun How come there's such a huge change in the package without even a stable release in the meantime? Is this a solid depreciation plan? Removing the deprecated APIs and even the ability to install during a pre-release phase? Older SDK versions don't work due to these changes, users need to find out the hard way what extra dependencies they need to install (I'm referring to the Is there a way for a user to pull the "old" As it seems, we have delivered the API for namespaced pipelines but the client all users use can't have it. Do you have a detailed plan exposed somewhere? Users use v1 pipelines for their production and they will hardly transition to v2 until quite some time after a GA of v2 pipelines gets out. Since this is far enough in terms of time, it doesn't make sense to make it difficult to use the deprecated v1 API. |
@elikatsis interestingly #8831 has just been merged |
@StefanoFioravanzo @elikatsis @chensun |
@elikatsis, I'm starting the v2 API migration in SDK client, this feature will be covered as part of that. And it would be available in the next SDK beta release. |
Description of your changes:
Add a namespace field in the relevant Python wrappers for uploading namespaced pipeline definitions.
This is the SDK part pushed by #8196. See the aforementioned PR and the linked issued for details.
This PR is part of the overarching idea to support namespaced pipeline definitions.
The whole idea is thoroughly analyzed and exposed in this design doc: https://docs.google.com/document/d/1fM4y2L1IVqVj-iiNjYFRRktdCh7FQXgU2XpaYLaqt-A/edit?resourcekey=0-kd5loyP7w3PBD0ug6ECmLQ#
Objective of this PR is to:
Part of #4197
Blocked by #8511 +
kfp-server-api
releaseChecklist: