-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove webpack from dependency #5076
Conversation
/assign @zijianjoy |
/lgtm Thank you Yuan for fixing the dependency versioning issue! Normally I would prefer to see the webpack version being set explicitly (since the version of module bundling tool might affect the build result), but understanding that this is for resolving the renovate dashboard PR issue. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, zijianjoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, zijianjoy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@zijianjoy For clarification, that was not the only reason. The reason we included webpack directly before, was because we migrated to |
That makes sense, thank you for the clarification! |
Description of your changes:
Part of #4682
A problem I saw:
renovate updated webpack, but not react-scripts. Then frontend fails to build because each version of
react-scripts
works with a specific chosen version of webpack.Change in this PR:
Remove webpack from dependency, and include it via react-scripts's transitive dependency.
In this way, webpack's version will be decided by react-scripts, so they won't be out-of-sync during renovate auto-upgrade.
Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.