Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: pin pip to fix a weird version resolution logic #4852

Merged
merged 4 commits into from
Dec 1, 2020

Conversation

numerology
Copy link

@numerology numerology commented Dec 1, 2020

Description of your changes:

It looks like in pip 20.3 it will scan through all available version of promise in order to get a compatible one. Then the test process failed due to a bad promise version.

Checklist:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: numerology

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@numerology
Copy link
Author

/test kubeflow-pipelines-tfx-python36

@numerology
Copy link
Author

/test kubeflow-pipelines-tfx-python36

@numerology
Copy link
Author

/test kubeflow-pipelines-tfx-python36

@numerology numerology changed the title test: pin promise because of a bad version test: pin pip to fix a weird version resolution logic Dec 1, 2020
@chensun
Copy link
Member

chensun commented Dec 1, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Dec 1, 2020
@numerology
Copy link
Author

/test kubeflow-pipelines-tfx-python36

@numerology numerology marked this pull request as ready for review December 1, 2020 20:55
@numerology
Copy link
Author

/assign @chensun

@chensun
Copy link
Member

chensun commented Dec 1, 2020

/lgtm

Thanks!

@chensun
Copy link
Member

chensun commented Dec 1, 2020

Fixes #4853

@k8s-ci-robot k8s-ci-robot merged commit 9631eb9 into kubeflow:master Dec 1, 2020
@numerology numerology deleted the fix-test branch December 1, 2020 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants