Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend/backend): Allow the ability to sort experiments by last run creation. Fixes #10884 #11163

Merged
merged 5 commits into from
Sep 25, 2024
Merged

feat(frontend/backend): Allow the ability to sort experiments by last run creation. Fixes #10884 #11163

merged 5 commits into from
Sep 25, 2024

Conversation

ElayAharoni
Copy link
Contributor

@ElayAharoni ElayAharoni commented Sep 3, 2024 •
edited
Loading

Fixes #10884.

I cherry picked @HumairAK commit for the BE side.
and did the necessary changes to the FE side.
also built the image and tested the behaviour, it works as requested. (attached video of the new behaviour).
https://www.loom.com/share/4ce09c4c87464285a744cff42d42aa2f?sid=e65c93d4-3116-4f05-8066-66fd0115de63

@google-oss-prow Google OSS Prow
Copy link

Hi @ElayAharoni. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gregsheremeta
UPSTREAM: <carry>: chore(backend): Rename UpdateLastRun -> SetLastRun…
60e266e 
…Timestamp

follup up to bf77909. Rename UpdateLastRun -> SetLastRunTimestamp

also tweak a related log message

Signed-off-by: Greg Sheremeta <[email protected]>
@hbelmiro
Copy link
Contributor

hbelmiro commented Sep 3, 2024

/ok-to-test

gregsheremeta and others added 2 commits September 3, 2024 16:31
@gregsheremeta
UPSTREAM: <carry>: chore(backend): Rename UpdateLastRun -> SetLastRun…
8e7a0a4 
…Timestamp

follup up to bf77909. Rename UpdateLastRun -> SetLastRunTimestamp

also tweak a related log message

Signed-off-by: Greg Sheremeta <[email protected]>
Merge remote-tracking branch 'origin/Allow-the-ability-to-sort-Experi…
a036042 
…ments-by-last-run-creation-#10884' into Allow-the-ability-to-sort-Experiments-by-last-run-creation-kubeflow#10884
HumairAK
HumairAK reviewed Sep 3, 2024
View reviewed changes
backend/src/apiserver/model/experiment.go
Name string `gorm:"column:Name; not null; unique_index:idx_name_namespace;"`
Description string `gorm:"column:Description; not null;"`
CreatedAtInSec int64 `gorm:"column:CreatedAtInSec; not null;"`
LastRunCreatedAtInSec int64 `gorm:"column:LastRunCreatedAtInSec; not null;"`
Copy link
Collaborator

@HumairAK HumairAK Sep 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chensun fyi, this change adds a new column to Experiment table to allow for tracking for the last created run. This is required because list sorting performs sql sort operations on columns under the hood, and currently there is no way to do this with the existing schema.

Also note here: https://github.com/kubeflow/pipelines/pull/11163/files#diff-62d02d47cfac0eb11fdad7cf760bac31eb64f26e05aec490934c05bfd7949c09R569 which makes an additional db call during run creation calls.

WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding new columns should be fine. Thanks for the callout.

@ElayAharoni ElayAharoni mentioned this pull request Sep 17, 2024
Closed
@HumairAK
Copy link
Collaborator

HumairAK commented Sep 17, 2024 •
edited
Loading

cc @chensun , please see comments above

chensun
chensun approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Sep 25, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit db8669c into kubeflow:master Sep 25, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HumairAK HumairAK HumairAK left review comments

@chensun chensun chensun approved these changes

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@chensun chensun

Labels
approved lgtm ok-to-test size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] Allow the ability to sort Experiments by "last run creation"
5 participants
@ElayAharoni @hbelmiro @HumairAK @chensun @gregsheremeta