Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sample): add note about secret needing to be pre-created #10659

Merged

Conversation

gregsheremeta
Copy link
Contributor

Description of your changes:
these samples currently only work on the Google Cloud distribution because of hardcoded secret name that only pre-exists there.
1 extract the hardcoded secret name to a const to make it a little easier to change
2 add a note about it.

Checklist:

Copy link

Hi @gregsheremeta. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@gregsheremeta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 d0cf525 link false /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

these samples currently only work on the Google Cloud distribution
because of hardcoded secret name that only pre-exists there.
1 extract the hardcoded secret name to a const to make it a little
easier to change
2 add a note about it.

Signed-off-by: Greg Sheremeta <[email protected]>
@gregsheremeta
Copy link
Contributor Author

thanks @connor-mccarthy . Can you re-tag? I had to add the signed-off-by.

@rimolive
Copy link
Member

rimolive commented Apr 9, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 9, 2024
@google-oss-prow google-oss-prow bot merged commit f10b773 into kubeflow:master Apr 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants