-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sample): add note about secret needing to be pre-created #10659
chore(sample): add note about secret needing to be pre-created #10659
Conversation
Hi @gregsheremeta. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: connor-mccarthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gregsheremeta: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
these samples currently only work on the Google Cloud distribution because of hardcoded secret name that only pre-exists there. 1 extract the hardcoded secret name to a const to make it a little easier to change 2 add a note about it. Signed-off-by: Greg Sheremeta <[email protected]>
d0cf525
to
9ada9c2
Compare
thanks @connor-mccarthy . Can you re-tag? I had to add the signed-off-by. |
/lgtm |
Description of your changes:
these samples currently only work on the Google Cloud distribution because of hardcoded secret name that only pre-exists there.
1 extract the hardcoded secret name to a const to make it a little easier to change
2 add a note about it.
Checklist: