-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kubernetes_platform): Update kubernetes_platform go package to include node affinities and pod (anti)affinities #10583
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @cjidboon94. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @chensun
I see there's still a few things missing in the proto. There's no way to distinguish between matchExpressions/matchLabels/matchFields (currently assumed it was all just matchExpressions). And there's some namespace selection stuff that are missing for PodAffinity. Willl add these tomorrow https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.25/#podaffinityterm-v1-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cjidboon94 Can you please rebase this PR? |
…nclude nodeaffinities and pod (anti)affinities Signed-off-by: Cornelis Boon <[email protected]>
Signed-off-by: Cornelis Boon <[email protected]>
Signed-off-by: Cornelis Boon <[email protected]>
Done |
@cjidboon94: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
…nclude node affinities and pod (anti)affinities (kubeflow#10583) * feat(kubernetes_platform): Update kubernetes_platform go package to include nodeaffinities and pod (anti)affinities Signed-off-by: Cornelis Boon <[email protected]> * rename affinity objects and fields to match k8s spec semantics Signed-off-by: Cornelis Boon <[email protected]> * rename *AffinityRule -> *AffinityTerm and add missing affinity data Signed-off-by: Cornelis Boon <[email protected]> --------- Signed-off-by: Cornelis Boon <[email protected]>
…nclude node affinities and pod (anti)affinities (kubeflow#10583) * feat(kubernetes_platform): Update kubernetes_platform go package to include nodeaffinities and pod (anti)affinities Signed-off-by: Cornelis Boon <[email protected]> * rename affinity objects and fields to match k8s spec semantics Signed-off-by: Cornelis Boon <[email protected]> * rename *AffinityRule -> *AffinityTerm and add missing affinity data Signed-off-by: Cornelis Boon <[email protected]> --------- Signed-off-by: Cornelis Boon <[email protected]>
Description of your changes:
Part of #9768 and #9682
This PR adds Node Affinities and Pod Affinities and Anti-Affinities to the kubernetes platform proto file. It also regenerates the Golang stub.
To quote @droctothorpe mentioned in his PR
All the relevant information about node affinities and pod (anti)affinity is captured in the NodeAffinity and PodAffinity proto messages and should be enough to generate all possible node- and podaffinities.
Checklist: