Skip to content

Commit

Permalink
Move S3 and Minio artifacts to /var/run/kfp/artifact
Browse files Browse the repository at this point in the history
  • Loading branch information
judahrand committed Sep 10, 2021
1 parent d8cf9cb commit 65ad66b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions sdk/python/kfp/v2/components/types/artifact_types.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@
"""

import os
from pathlib import Path
from typing import Dict, Generic, List, Optional, Type, TypeVar, Union

_GCS_LOCAL_MOUNT_PREFIX = '/gcs/'
_MINIO_LOCAL_MOUNT_PREFIX = '/minio/'
_S3_LOCAL_MOUNT_PREFIX = '/s3/'
_MINIO_LOCAL_MOUNT_PREFIX = '/var/run/kfp/artifact/minio/'
_S3_LOCAL_MOUNT_PREFIX = '/var/run/kfp/artifact/s3/'


class Artifact(object):
Expand Down
4 changes: 2 additions & 2 deletions v2/component/launcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -655,10 +655,10 @@ func localPathForURI(uri string) (string, error) {
return "/gcs/" + strings.TrimPrefix(uri, "gs://"), nil
}
if strings.HasPrefix(uri, "minio://") {
return "/minio/" + strings.TrimPrefix(uri, "minio://"), nil
return "/var/run/kfp/artifact/minio/" + strings.TrimPrefix(uri, "minio://"), nil
}
if strings.HasPrefix(uri, "s3://") {
return "/s3/" + strings.TrimPrefix(uri, "s3://"), nil
return "/var/run/kfp/artifact/s3/" + strings.TrimPrefix(uri, "s3://"), nil
}
return "", fmt.Errorf("failed to generate local path for URI %s: unsupported storage scheme", uri)
}
Expand Down

0 comments on commit 65ad66b

Please sign in to comment.