Skip to content

ci: Upgrade Python to 3.12 and NodeJS to 24 for all imaged under example-notebook-servers #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: notebooks-v1
Choose a base branch
from
Open

ci: Upgrade Python to 3.12 and NodeJS to 24 for all imaged under example-notebook-servers #756

wants to merge 1 commit into from
+14 −16

Conversation

@liavweiss
Copy link

@liavweiss liavweiss commented Nov 18, 2025 •
edited
Loading

closes: #727 #732

Title

Upgrade Python to 3.12 and Node to 24 across example-notebook-servers (Gaudi images excluded for now).

Summary

  • Upgrades Python to 3.12.6 in all example-notebook-servers images.
  • Upgrade Node to 24 in all jupyter images.
  • Explicitly keeps Gaudi images on Python 3.10.16 due to vendor wheel (cp310) and SynapseAI matrix constraints.

Validation:

  • example_notebook_servers_publish.yaml passed successfully and built all images. image
  • Creating notebooks from few images:
    • jupyter
image
  • jupyter-tensorflow-cuda
image
  • code-server-python
image
  • rsudio
image

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Nov 18, 2025
@google-oss-prow
Copy link

google-oss-prow bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign thesuperzapper for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added the area/server-images area - related to the notebook server images label Nov 18, 2025
@google-oss-prow google-oss-prow bot added area/v1 area - version - kubeflow notebooks v1 size/S labels Nov 18, 2025
@liavweiss liavweiss marked this pull request as draft November 18, 2025 10:55
yehudit1987
yehudit1987 reviewed Nov 18, 2025
View reviewed changes
components/example-notebook-servers/jupyter-tensorflow-cuda/Dockerfile Outdated
# install - tensorflow
# - About '[and-cuda]' option: https://github.com/tensorflow/tensorflow/blob/v2.17.1/tensorflow/tools/pip_package/setup.py#L153-L164
# - TODO: when updating TensorRT, you might need to change `tensorrt`, `tensorrt-libs`, and `tensorrt-bindings`
# to `tensorrt-cu12`, `tensorrt-cu12-libs`, and `tensorrt-cu12-bindings` respectively
Copy link

@yehudit1987 yehudit1987 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This TODO comment was actually completed in this PR - you've successfully migrated from tensorrt to tensorrt-cu12 packages. Consider removing this TODO or marking it as resolved:

yehudit1987
yehudit1987 reviewed Nov 18, 2025
View reviewed changes
components/example-notebook-servers/jupyter-tensorflow-cuda/Dockerfile Outdated
# - https://github.com/tensorflow/tensorflow/issues/61986#issuecomment-1880489731
# - We are creating symlinks for the following libs, as this is where TF looks for them:
# - libnvinfer.so.8.6.1 -> libnvinfer.so.8
# - libnvinfer_plugin.so.8.6.1 -> libnvinfer_plugin.so.8
Copy link

@yehudit1987 yehudit1987 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments here still reference the old TensorRT version 8.6.1, but should be updated to reflect the new version 10.2.0:
Current comments mention libnvinfer.so.8.6.1 -> libnvinfer.so.8
Should be: libnvinfer.so.10.2.0 -> libnvinfer.so.10

@liavweiss liavweiss changed the title Upgrade Python to 3.12 and NodeJS to 24 for all imaged under example-notebook-servers ci: Upgrade Python to 3.12 and NodeJS to 24 for all imaged under example-notebook-servers Nov 18, 2025
@liavweiss liavweiss force-pushed the feature/python-3.12-example-notebook-server branch from b2bd67f to 8c58130 Compare November 18, 2025 13:41
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Nov 18, 2025
@yehudit1987
Copy link

yehudit1987 commented Nov 18, 2025

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 18, 2025
@liavweiss liavweiss marked this pull request as ready for review November 19, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

@thesuperzapper thesuperzapper Awaiting requested review from thesuperzapper

1 more reviewer

@yehudit1987 yehudit1987 yehudit1987 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@yehudit1987 yehudit1987

Labels

area/server-images area - related to the notebook server images area/v1 area - version - kubeflow notebooks v1 lgtm size/M

Projects

Kubeflow Notebooks
Status: Needs Triage

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liavweiss @yehudit1987