feat: Implement "Create New Secret" Modal #751

jenny-s51 · 2025-11-17T19:51:55Z

Closes #661
Related: #667 , #698

google-oss-prow · 2025-11-17T19:52:05Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign paulovmr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

workspaces/frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

workspaces/frontend/src/app/pages/Workspaces/Form/properties/secrets/SecretsApiCreateModal.tsx

thaorell · 2025-11-21T15:46:39Z

workspaces/frontend/src/app/pages/Workspaces/Form/properties/secrets/SecretsApiCreateModal.tsx

+          </Alert>
+        )}
+        <Form>
+          <ThemeAwareFormGroupWrapper label="Secret name" isRequired fieldId="secret-name">


We should include a dropdown here to select a Secret Type. The only type supported is "Opaque", but ideally we would want to conditionally render the input field (i.e. if Opaque, then display Value-Pair)

Thank you @thaorell , yes, great point - added a "Secret Type dropdown" per your feedback. Since there's just one type supported at the moment I've disabled it for now. WDYT?

MUI has it's own styling for disabled dropdowns which is tracked in opendatahub-io/mod-arch-library#65 and will be handled as a followup.

Signed-off-by: Charles Thao <[email protected]> Signed-off-by: Jenny <[email protected]>

Signed-off-by: Jenny <[email protected]>

Signed-off-by: Jenny <[email protected]> remove unused div and inline styles Signed-off-by: Jenny <[email protected]>

Signed-off-by: Jenny <[email protected]>

github-project-automation bot added this to Kubeflow Notebooks Nov 17, 2025

github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Nov 17, 2025

jenny-s51 marked this pull request as draft November 17, 2025 19:51

google-oss-prow bot added do-not-merge/work-in-progress area/frontend area - related to frontend components labels Nov 17, 2025

google-oss-prow bot requested review from ederign and paulovmr November 17, 2025 19:52

google-oss-prow bot added area/v2 area - version - kubeflow notebooks v2 size/XL labels Nov 17, 2025

jenny-s51 marked this pull request as ready for review November 20, 2025 21:38

google-oss-prow bot removed the do-not-merge/work-in-progress label Nov 20, 2025

jenny-s51 force-pushed the secrets-creation-modal branch 2 times, most recently from 86bc28d to a44fe37 Compare November 20, 2025 21:46