ci: add notebooks controller test workflows #642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow to notebooks-v1 branch Signed-off-by: Abdallah Samara (EXT-Nokia) <[email protected]>
This was referenced Oct 6, 2025
Closed
|
/ok-to-test |
andyatmiami
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
Thank you for addressing the requested changes originally submitted against #621.
I have pulled in these changes to my fork and then verified a change within notebook-controller directory properly kicks off the referenced workflows - and more importantly, that those workflows succeed
thesuperzapper
changed the title
|
Thanks @abdallahsamabd and @andyatmiami /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit d7e2ba3
into
kubeflow:notebooks-v1
14 of 16 checks passed
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #590