feat: add Kubernetes-layer dry-run validation for WorkspaceKind … #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bhaktinarvekar
changed the title
…creation This update enhances the WorkspaceKind POST API to properly perform dry-run validation at the Kubernetes API layer. When `dry_run=true` is specified, the request now invokes controller-runtime’s Create API with dry-run semantics, allowing validation errors to be surfaced directly from Kubernetes (e.g., schema or webhook errors). Changes include: - Added CreateOptions with DryRunAll for dry-run requests - Unified create logic for both dry-run and normal requests - Improved error propagation and response mapping - Updated tests for dry-run and standard create flows Signed-off-by: Bhakti Narvekar <[email protected]>
bhaktinarvekar
force-pushed
the
issue_417_v1
branch
from
485824d to
61d200f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…creation
This update enhances the WorkspaceKind POST API to properly perform dry-run validation at the Kubernetes API layer. When
dry_run=trueis specified, the request now invokes controller-runtime’s Create API with dry-run semantics, allowing validation errors to be surfaced directly from Kubernetes (e.g., schema or webhook errors).Changes include: