feat: Migrate pvcviewer controller publish action #622
+67
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
added
do-not-merge/work-in-progress
area/ci
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
noalimoy
force-pushed
the
feature/migrate_pvcviewer_controller_docker_publish_to_notebooks
branch
2 times, most recently
from
425e4da to
53689ac
Compare
|
/hold I want to make sure:
|
noalimoy
force-pushed
the
feature/migrate_pvcviewer_controller_docker_publish_to_notebooks
branch
from
53689ac to
0636c9a
Compare
google-oss-prow
bot
added
area/controller
noalimoy
force-pushed
the
feature/migrate_pvcviewer_controller_docker_publish_to_notebooks
branch
3 times, most recently
from
88afc72 to
104bfe1
Compare
Signed-off-by: noa limoy <[email protected]>
noalimoy
force-pushed
the
feature/migrate_pvcviewer_controller_docker_publish_to_notebooks
branch
from
104bfe1 to
832a156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR migrates the GitHub Actions workflow responsible for building and publishing the PVCViewer Controller Docker image from the
kubeflow/kubeflowrepository to thekubeflow/notebooksrepository.Related: #619
Verification
Successfully built and published a test image:
GitHub Actions run