fix(nb): fix default workspace volume name to match default configs

[mathis-marcotte]

Small fix to improve consistency in the default workspace volume name when creating a new Notebook.

I noticed that on initial load of the crud-web-apps/jupyter form, the default workspace volume name was "{notebook-name}-workspace".
But if you deleted that workspace volume, and then re-added a workspace volume to the Notebook you are creating, then the workspace volume name was "{notebook-name}-volume".

This PR is to FIX the default name of the workspace volume to always follow the same standard of "{notebook-name}-workspace" to match with the default configs.

Original PR here: kubeflow/kubeflow#7705

[google-oss-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign orfeas-k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• components/crud-web-apps/jupyter/frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyatmiami]

/area v1

[andyatmiami]

Hi @mathis-marcotte - do you think as part of this change you could add an assertion (or provide a new test entirely) here to validate this change as well?

• https://github.com/kubeflow/notebooks/blob/notebooks-v1/components/crud-web-apps/jupyter/frontend/src/app/pages/form/form-new/form-workspace-volume/form-workspace-volume.component.spec.ts

Thanks for the contribution as well as re-opening on this "new" repo!
🙇

[mathis-marcotte]

Hi @andyatmiami,
Yes I can totally add that assertion! Once I have some extra time soon, I will get that done.

[mathis-marcotte]

@andyatmiami

Added the new test case for validating this change. Tested locally with npm run test and everything passed.

Let me know if there is anything else I can do to improve this PR

[andyatmiami]

@mathis-marcotte

thank you for making this addition.. i'm a little back-logged on my PR reviewing - but would expect to be able to focus on this mid-next week.

will be in touch!