Skip to content

Conversation

caponetto
Copy link

This pull request introduces a major refactor and enhancement to the frontend workspace's environment and build configuration. The changes standardize environment variable management across different environments, improve webpack configuration modularity, and make the development setup more robust and flexible. Key updates include the addition of a custom dotenv management utility, significant rewrites of webpack configs to leverage this utility, and improvements to local development and build processes. These changes are meant to be in sync with Model Registry.

Environment variable and dotenv management:

  • Added a new config/dotenv.js utility to handle loading and expanding environment variables, supporting both root and nested project structures, and integrating with webpack via plugins.
  • Updated all .env* files to include relevant variables for branding, deployment mode, and environment-specific settings, ensuring consistent configuration across development, production, and testing.

Webpack configuration refactor:

  • Refactored webpack.common.js and webpack.dev.js to use the new dotenv utility, moving away from hardcoded paths and variables. This enables dynamic configuration based on environment variables and simplifies path management.
  • Enhanced the webpack dev server setup with better proxy header handling, hot reloading, and improved output/logging for local development.

Build and asset handling improvements:

  • Improved asset copying and handling in webpack, ensuring that images, favicons, locales, and other static files are correctly managed for all build targets.
  • Updated babel configuration with presets for React, TypeScript, and targeted browsers, ensuring modern JS features are transpiled appropriately.

Documentation and developer experience:

  • Updated README.md to clarify that the UI runs with mocked data by default and how to control backend connectivity via the environment.
  • Added new words to the spell-check ignore list and updated style paths to support PatternFly extensions.

Other housekeeping:

  • Removed .env from .gitignore to allow versioning of environment templates, and made minor cleanups to support the new structure.

These changes collectively make the frontend workspace more maintainable, configurable, and developer-friendly.

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Aug 21, 2025
@google-oss-prow google-oss-prow bot added area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 size/XXL labels Aug 21, 2025
@caponetto caponetto force-pushed the infra-improvements branch 2 times, most recently from cec982a to 1f356ed Compare August 21, 2025 14:28
@paulovmr
Copy link

/ok-to-test

Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ederign
Copy link
Member

ederign commented Aug 26, 2025

/approve
/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 33319b1 into kubeflow:notebooks-v2 Aug 26, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Aug 26, 2025
yashpal2104 pushed a commit to yashpal2104/notebooks that referenced this pull request Sep 7, 2025
bhaktinarvekar pushed a commit to bhaktinarvekar/notebooks that referenced this pull request Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 lgtm ok-to-test size/XXL

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants