Skip to content

Conversation

caponetto
Copy link

@caponetto caponetto commented Aug 11, 2025

This pull request adds comprehensive unit tests for all custom React hooks in the workspaces/frontend/src/app/hooks directory. The new tests cover a wide range of scenarios, including API availability, context usage, and correct hook behavior under various conditions. This significantly improves the reliability and maintainability of the hooks by ensuring their expected behavior is validated.

Signed-off-by: Guilherme Caponetto <[email protected]>
@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Aug 11, 2025
@google-oss-prow google-oss-prow bot added area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 labels Aug 11, 2025
@paulovmr
Copy link

/ok-to-test

Copy link

@paulovmr paulovmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@ederign ederign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 265d5af into kubeflow:notebooks-v2 Aug 12, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Aug 12, 2025
yashpal2104 pushed a commit to yashpal2104/notebooks that referenced this pull request Sep 7, 2025
bhaktinarvekar pushed a commit to bhaktinarvekar/notebooks that referenced this pull request Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 lgtm ok-to-test size/XL

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants