Skip to content

feat(ws): add manifests for frontend #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2025
Merged

feat(ws): add manifests for frontend #487

merged 2 commits into from
Aug 21, 2025

Conversation

noalimoy
Copy link

closes: #404

In this PR I have deployed the frontend component to Kubernetes using Kustomize.

  • The frontend deployment is applied under config/manifests/kustomize/base directory
  • An Istio VirtualService is defined under options/istio directory, (exposing the /workspaces path)
  • Deployment enters READY state and is available.

@github-project-automation github-project-automation bot moved this to Needs Triage in Kubeflow Notebooks Jul 17, 2025
@google-oss-prow google-oss-prow bot added area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 labels Jul 17, 2025
andyatmiami
andyatmiami suggested changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@andyatmiami andyatmiami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll ask for a couple quick edits that jump out now - but please be aware I'll do a much more comprehensive review on Monday where I will try to deploy these changes along with base Kubeflow manifests and backend component to exercise end-to-end functionality.

For now, 2 easy "structure" changes I will ask for:

  • workspaces/frontend/manifests/kustomize should be the "base" directory (no /config folder)
  • options/istio should be the root folder in which you place the istio-specific resources

andyatmiami
andyatmiami reviewed Jul 17, 2025
View reviewed changes
workspaces/frontend/config/manifests/kustomize/base/deployment.yaml Outdated
livenessProbe:
httpGet:
path: /
port: 8080
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the named port value of http-frontend here

andyatmiami
andyatmiami reviewed Jul 17, 2025
View reviewed changes
workspaces/frontend/config/manifests/kustomize/base/deployment.yaml Outdated
readinessProbe:
httpGet:
path: /
port: 8080
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see: https://github.com/kubeflow/notebooks/pull/487/files#r2213929718

@noalimoy noalimoy force-pushed the frontend_k8s_deploy/404 branch 2 times, most recently from 7edcef8 to 7c11794 Compare July 24, 2025 12:39
harshad16
harshad16 suggested changes Jul 28, 2025
View reviewed changes
Copy link

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some minor discrepancy

@google-oss-prow Google OSS Prow
Copy link

@harshad16: changing LGTM is restricted to collaborators

In response to this:

Found some minor discrepancy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@noalimoy noalimoy force-pushed the frontend_k8s_deploy/404 branch from 7c11794 to a2a8b17 Compare August 5, 2025 12:29
@andyatmiami
Copy link
Contributor

/lgtm

verified these changes with help of a script I have been working on to deploy Central Dashboard in kind ... can confirm frontend component is successfully deployed and served up within Central Dashboard.

user requests to backend are also successfully processed.

@google-oss-prow google-oss-prow bot added the lgtm label Aug 6, 2025
@andyatmiami
Copy link
Contributor

/ok-to-test

@noalimoy noalimoy force-pushed the frontend_k8s_deploy/404 branch from a2a8b17 to 92bdb7f Compare August 21, 2025 14:13
@google-oss-prow google-oss-prow bot removed the lgtm label Aug 21, 2025
@andyatmiami
Copy link
Contributor

/lgtm

re-verified the end-to-end of running kubeflow/notebooks frontend and backend components off the commit in this PR and confirmed traffic properly routed.

@google-oss-prow google-oss-prow bot added the lgtm label Aug 21, 2025
@thesuperzapper thesuperzapper changed the title feat(ws): Define k8s workload manifest for frontend component #404 feat(ws): add manifests for frontend Aug 21, 2025
@google-oss-prow google-oss-prow bot removed the lgtm label Aug 21, 2025
@thesuperzapper
Copy link
Member

Thanks @Noa-limoy and @andyatmiami.

Great step towards end-to-end deployment of Notebooks v2.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Aug 21, 2025
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ebd5d2c into kubeflow:notebooks-v2 Aug 21, 2025
6 of 7 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Kubeflow Notebooks Aug 21, 2025
@noalimoy noalimoy mentioned this pull request Sep 2, 2025
Open
yashpal2104 pushed a commit to yashpal2104/notebooks that referenced this pull request Sep 7, 2025
@noalimoy @andyatmiami @yashpal2104
feat(ws): add manifests for frontend (kubeflow#487)
97349da 
* feat(ws): Define k8s workload manifest for frontend component kubeflow#404

Signed-off-by: Noa <[email protected]>

* fix: virtual-service tweaks from review

Signed-off-by: Andy Stoneberg <[email protected]>

---------

Signed-off-by: Noa <[email protected]>
Signed-off-by: Andy Stoneberg <[email protected]>
Co-authored-by: Andy Stoneberg <[email protected]>
bhaktinarvekar pushed a commit to bhaktinarvekar/notebooks that referenced this pull request Sep 14, 2025
@noalimoy @andyatmiami
feat(ws): add manifests for frontend (kubeflow#487)
42ffd9b 
* feat(ws): Define k8s workload manifest for frontend component kubeflow#404

Signed-off-by: Noa <[email protected]>

* fix: virtual-service tweaks from review

Signed-off-by: Andy Stoneberg <[email protected]>

---------

Signed-off-by: Noa <[email protected]>
Signed-off-by: Andy Stoneberg <[email protected]>
Co-authored-by: Andy Stoneberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ederign ederign Awaiting requested review from ederign

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

@paulovmr paulovmr Awaiting requested review from paulovmr

2 more reviewers

@harshad16 harshad16 harshad16 requested changes

@andyatmiami andyatmiami andyatmiami approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@thesuperzapper thesuperzapper

@andyatmiami andyatmiami

Labels

approved area/frontend area - related to frontend components area/v2 area - version - kubeflow notebooks v2 lgtm ok-to-test size/L

Projects

Kubeflow Notebooks
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@noalimoy @andyatmiami @thesuperzapper @harshad16