fix(ws): Improve Workspace Creation Wizard Step Descriptions #452
Conversation
google-oss-prow
bot
added
area/frontend
| const stepDescriptions: { [key in WorkspaceFormSteps]?: string } = { | ||
| [WorkspaceFormSteps.KindSelection]: 'Select a workspace kind to use for the workspace.', | ||
| [WorkspaceFormSteps.KindSelection]: | ||
| 'A workspace kind is a template that creates an isolated area where you can work with models in your preferred IDE, such as a Jupyter notebook.', |
There was a problem hiding this comment.
isolated area
that isolated area is to be called a workspace, maybe this information can be weaved into it somehow too?
| const stepDescriptions: { [key in WorkspaceFormSteps]?: string } = { | ||
| [WorkspaceFormSteps.KindSelection]: 'Select a workspace kind to use for the workspace.', | ||
| [WorkspaceFormSteps.KindSelection]: | ||
| 'A workspace kind is a template that creates an isolated area where you can work with models in your preferred IDE, such as a Jupyter notebook.', |
There was a problem hiding this comment.
your preferred IDE, such as a Jupyter notebook
this is not wrong, but I'd prefer to say "such as Jupyter Notebook" (leave out the a), or "such as JupyterLab". What do you all think?
| [WorkspaceFormSteps.PodConfigSelection]: 'Select a pod config to use for the workspace.', | ||
| 'Select a workspace image and image version to use for the workspace. A workspace image is a container image that contains the software and dependencies needed to run a workspace.', | ||
| [WorkspaceFormSteps.PodConfigSelection]: | ||
| 'Select a pod config to use for the workspace. A pod config is a configuration that defines the resources and settings for a workspace pod.', |
There was a problem hiding this comment.
for a workspace pod
maybe leave out pod?
Signed-off-by: Jenny <[email protected]> Changes to step descriptions based on feedback
jenny-s51
force-pushed
the
add-step-1-context
branch
from
49796ad to
5a1bd23
Compare
There was a problem hiding this comment.
Thank you @jiridanek for your review! Appreciate your feedback, and these are great points. Updated to reflect your suggestions.
|
/ok-to-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
…w#452) Signed-off-by: Jenny <[email protected]> Changes to step descriptions based on feedback
4 participants
Closes #373
Description
This PR enhances the workspace creation wizard by providing more context for each step in the form flow.
Includes updated step descriptions for:
This enhancement improves the workspace creation process by helping users understand what to select and why each step matters for their workspace setup.