chore(ws): enforce named imports for react hooks #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test |
|
/lgtm |
|
@paulovmr PR lgtm, but needs a rebase. |
Signed-off-by: paulovmr <[email protected]>
paulovmr
force-pushed
the
notebooks-v2-standardize-react-imports
branch
from
93101db to
7a41950
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ederign The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 6f6ba50
into
kubeflow:notebooks-v2
6 of 7 checks passed
github-project-automation
bot
moved this from Needs Triage
to Done
in Kubeflow Notebooks
bhaktinarvekar
pushed a commit
to bhaktinarvekar/notebooks
that referenced
this pull request
Sep 14, 2025
Signed-off-by: paulovmr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some typescript files use named imports and others use namespace imports to import React Hooks. This PR enforces through ESLint that React Hooks must be imported using named imports, as a way to organize and standardize the frontend code.
With this PR, if a React Hook is used with the
React.prefix, there will be a lint error, for example: