Update README with warning about migration #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathew Wicks <[email protected]>
|
/assign @kimwnasptd |
|
/lgmt |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd, thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@kimwnasptd you typoed the lgtm. |
Adembc
pushed a commit
to Adembc/notebooks
that referenced
this pull request
Jun 22, 2024
Signed-off-by: Mathew Wicks <[email protected]>
jenny-s51
added a commit
to jenny-s51/notebooks
that referenced
this pull request
Mar 12, 2025
jenny-s51
added a commit
to jenny-s51/notebooks
that referenced
this pull request
Mar 18, 2025
Signed-off-by: Jenny <[email protected]>
google-oss-prow bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
* feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * card view style fixes (#2) Signed-off-by: Jenny <[email protected]> * fix(ws): fix scroll behavior with PageGroup Signed-off-by: Jenny <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * fix(ws): Apply flex-grow: 0 to page section Signed-off-by: Jenny <[email protected]> --------- Signed-off-by: paulovmr <[email protected]> Signed-off-by: Jenny <[email protected]> Co-authored-by: Jenny <[email protected]>
caponetto
referenced
this pull request
in caponetto/kubeflow-notebooks
Apr 30, 2025
* feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * card view style fixes (#2) Signed-off-by: Jenny <[email protected]> * fix(ws): fix scroll behavior with PageGroup Signed-off-by: Jenny <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * fix(ws): Apply flex-grow: 0 to page section Signed-off-by: Jenny <[email protected]> --------- Signed-off-by: paulovmr <[email protected]> Signed-off-by: Jenny <[email protected]> Co-authored-by: Jenny <[email protected]>
Mohamed-ben-khemis
pushed a commit
to Mohamed-ben-khemis/notebooks
that referenced
this pull request
May 5, 2025
* feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * card view style fixes (kubeflow#2) Signed-off-by: Jenny <[email protected]> * fix(ws): fix scroll behavior with PageGroup Signed-off-by: Jenny <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * fix(ws): Apply flex-grow: 0 to page section Signed-off-by: Jenny <[email protected]> --------- Signed-off-by: paulovmr <[email protected]> Signed-off-by: Jenny <[email protected]> Co-authored-by: Jenny <[email protected]>
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
May 28, 2025
* feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * card view style fixes (kubeflow#2) Signed-off-by: Jenny <[email protected]> * fix(ws): fix scroll behavior with PageGroup Signed-off-by: Jenny <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * fix(ws): Apply flex-grow: 0 to page section Signed-off-by: Jenny <[email protected]> --------- Signed-off-by: paulovmr <[email protected]> Signed-off-by: Jenny <[email protected]> Co-authored-by: Jenny <[email protected]> Signed-off-by: CI Bot <[email protected]>
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
Jun 4, 2025
* feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * card view style fixes (kubeflow#2) Signed-off-by: Jenny <[email protected]> * fix(ws): fix scroll behavior with PageGroup Signed-off-by: Jenny <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * fix(ws): Apply flex-grow: 0 to page section Signed-off-by: Jenny <[email protected]> --------- Signed-off-by: paulovmr <[email protected]> Signed-off-by: Jenny <[email protected]> Co-authored-by: Jenny <[email protected]> Signed-off-by: CI Bot <[email protected]>
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
Jun 11, 2025
* feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * card view style fixes (kubeflow#2) Signed-off-by: Jenny <[email protected]> * fix(ws): fix scroll behavior with PageGroup Signed-off-by: Jenny <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * fix(ws): Apply flex-grow: 0 to page section Signed-off-by: Jenny <[email protected]> --------- Signed-off-by: paulovmr <[email protected]> Signed-off-by: Jenny <[email protected]> Co-authored-by: Jenny <[email protected]> Signed-off-by: CI Bot <[email protected]>
mkoushni
pushed a commit
to mkoushni/notebooks
that referenced
this pull request
Jun 11, 2025
* feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * card view style fixes (kubeflow#2) Signed-off-by: Jenny <[email protected]> * fix(ws): fix scroll behavior with PageGroup Signed-off-by: Jenny <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * fix(ws): Apply flex-grow: 0 to page section Signed-off-by: Jenny <[email protected]> --------- Signed-off-by: paulovmr <[email protected]> Signed-off-by: Jenny <[email protected]> Co-authored-by: Jenny <[email protected]> Signed-off-by: CI Bot <[email protected]>
andyatmiami
referenced
this pull request
in andyatmiami/kubeflow-notebooks
Jun 13, 2025
* feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * card view style fixes (#2) Signed-off-by: Jenny <[email protected]> * fix(ws): fix scroll behavior with PageGroup Signed-off-by: Jenny <[email protected]> * feat(ws): add initial workspace creation wizard frontend Signed-off-by: paulovmr <[email protected]> * fix(ws): Apply flex-grow: 0 to page section Signed-off-by: Jenny <[email protected]> --------- Signed-off-by: paulovmr <[email protected]> Signed-off-by: Jenny <[email protected]> Co-authored-by: Jenny <[email protected]>
google-oss-prow bot
pushed a commit
that referenced
this pull request
Jun 17, 2025
…nd it (#415) * Minor refactorings and initial work for the Workspace Kind summary page Signed-off-by: Guilherme Caponetto <[email protected]> * feat(ws): added links from workspace kind details drawer to workspace kinds details page (#1) Signed-off-by: Paulo Rego <[email protected]> * Enable workspace filtering by namespace in the WorkspaceKind summary page Signed-off-by: Guilherme Caponetto <[email protected]> * Update Pause/Start action response types according to backend Signed-off-by: Guilherme Caponetto <[email protected]> * Fix WorkspaceKind logo href Signed-off-by: Guilherme Caponetto <[email protected]> * Replace placeholders for GPU data with real values in WorkspaceKind summary page Signed-off-by: Guilherme Caponetto <[email protected]> * Allow columns to be hidden in the WorkspaceTable Signed-off-by: Guilherme Caponetto <[email protected]> * feat(ws): added links from workspace kind details drawer namespace tab to workspace kinds details page (#2) Signed-off-by: Paulo Rego <[email protected]> * Improve types around Filter component Signed-off-by: Guilherme Caponetto <[email protected]> * feat: Add Workspace Actions Context and related components - Introduced WorkspaceActionsContext to manage workspace actions such as view, edit, delete, start, restart, and stop. - Created WorkspaceActionsContextProvider to encapsulate the context logic and provide it to child components. - Implemented WorkspaceKindSummary and Workspaces components to utilize the new context for handling workspace actions. - Added polling for refreshing workspaces at a default interval. - Enhanced WorkspaceTable to support row actions for workspaces. - Updated various components to include sortable and filterable data fields. - Refactored WorkspaceStartActionModal and WorkspaceStopActionModal to handle optional onActionDone callback. - Added loading and error handling components for better user experience. Signed-off-by: Guilherme Caponetto <[email protected]> * feat: Add buildWorkspaceList function and integrate into mockAllWorkspaces Signed-off-by: Guilherme Caponetto <[email protected]> * refactor: Update mock data and formatting for workspace activity timestamps Signed-off-by: Guilherme Caponetto <[email protected]> * feat: Implement usePolling hook and refactor workspace actions in Workspaces and WorkspaceKindSummary components Signed-off-by: Guilherme Caponetto <[email protected]> * refactor: Update column key usage in ExpandedWorkspaceRow and adjust workspace actions visibility in Workspaces component Signed-off-by: Guilherme Caponetto <[email protected]> * Make mocked workspace list deterministic Signed-off-by: Guilherme Caponetto <[email protected]> * feat: Enhance WorkspaceTable with additional columns and filtering capabilities - Added 'namespace', 'gpu', and 'idleGpu' columns to WorkspaceTable. - Updated filtering logic to support new columns in WorkspaceTable. - Refactored useWorkspaces hook to remove unnecessary parameters related to idle and GPU filtering. - Modified WorkspaceKindSummary and its expandable card to utilize new filtering functionality. - Updated WorkspaceUtils to include a method for formatting workspace idle state. - Adjusted Filter component to support generic filtered column types. - Updated Workspaces page to hide new columns as needed. Signed-off-by: Guilherme Caponetto <[email protected]> * refactor: Improve sorting functionality in WorkspaceTable by utilizing specific types for sortable columns Signed-off-by: Guilherme Caponetto <[email protected]> * Adjustments after rebase Signed-off-by: Guilherme Caponetto <[email protected]> * Format with prettier Signed-off-by: Guilherme Caponetto <[email protected]> --------- Signed-off-by: Guilherme Caponetto <[email protected]> Signed-off-by: Paulo Rego <[email protected]> Co-authored-by: Paulo Rego <[email protected]>
bhaktinarvekar
pushed a commit
to bhaktinarvekar/notebooks
that referenced
this pull request
Sep 14, 2025
…nd it (kubeflow#415) * Minor refactorings and initial work for the Workspace Kind summary page Signed-off-by: Guilherme Caponetto <[email protected]> * feat(ws): added links from workspace kind details drawer to workspace kinds details page (kubeflow#1) Signed-off-by: Paulo Rego <[email protected]> * Enable workspace filtering by namespace in the WorkspaceKind summary page Signed-off-by: Guilherme Caponetto <[email protected]> * Update Pause/Start action response types according to backend Signed-off-by: Guilherme Caponetto <[email protected]> * Fix WorkspaceKind logo href Signed-off-by: Guilherme Caponetto <[email protected]> * Replace placeholders for GPU data with real values in WorkspaceKind summary page Signed-off-by: Guilherme Caponetto <[email protected]> * Allow columns to be hidden in the WorkspaceTable Signed-off-by: Guilherme Caponetto <[email protected]> * feat(ws): added links from workspace kind details drawer namespace tab to workspace kinds details page (kubeflow#2) Signed-off-by: Paulo Rego <[email protected]> * Improve types around Filter component Signed-off-by: Guilherme Caponetto <[email protected]> * feat: Add Workspace Actions Context and related components - Introduced WorkspaceActionsContext to manage workspace actions such as view, edit, delete, start, restart, and stop. - Created WorkspaceActionsContextProvider to encapsulate the context logic and provide it to child components. - Implemented WorkspaceKindSummary and Workspaces components to utilize the new context for handling workspace actions. - Added polling for refreshing workspaces at a default interval. - Enhanced WorkspaceTable to support row actions for workspaces. - Updated various components to include sortable and filterable data fields. - Refactored WorkspaceStartActionModal and WorkspaceStopActionModal to handle optional onActionDone callback. - Added loading and error handling components for better user experience. Signed-off-by: Guilherme Caponetto <[email protected]> * feat: Add buildWorkspaceList function and integrate into mockAllWorkspaces Signed-off-by: Guilherme Caponetto <[email protected]> * refactor: Update mock data and formatting for workspace activity timestamps Signed-off-by: Guilherme Caponetto <[email protected]> * feat: Implement usePolling hook and refactor workspace actions in Workspaces and WorkspaceKindSummary components Signed-off-by: Guilherme Caponetto <[email protected]> * refactor: Update column key usage in ExpandedWorkspaceRow and adjust workspace actions visibility in Workspaces component Signed-off-by: Guilherme Caponetto <[email protected]> * Make mocked workspace list deterministic Signed-off-by: Guilherme Caponetto <[email protected]> * feat: Enhance WorkspaceTable with additional columns and filtering capabilities - Added 'namespace', 'gpu', and 'idleGpu' columns to WorkspaceTable. - Updated filtering logic to support new columns in WorkspaceTable. - Refactored useWorkspaces hook to remove unnecessary parameters related to idle and GPU filtering. - Modified WorkspaceKindSummary and its expandable card to utilize new filtering functionality. - Updated WorkspaceUtils to include a method for formatting workspace idle state. - Adjusted Filter component to support generic filtered column types. - Updated Workspaces page to hide new columns as needed. Signed-off-by: Guilherme Caponetto <[email protected]> * refactor: Improve sorting functionality in WorkspaceTable by utilizing specific types for sortable columns Signed-off-by: Guilherme Caponetto <[email protected]> * Adjustments after rebase Signed-off-by: Guilherme Caponetto <[email protected]> * Format with prettier Signed-off-by: Guilherme Caponetto <[email protected]> --------- Signed-off-by: Guilherme Caponetto <[email protected]> Signed-off-by: Paulo Rego <[email protected]> Co-authored-by: Paulo Rego <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the README more clear about the fact that the Kubeflow Notebooks codebase currently lives on
kubeflow/kubeflow.