Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

Add v1beta1 and v1 kustomize manifest #81

Merged

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Jun 26, 2020

part of #66

Since we have v1beta1 and v1 CRDs at the same time. It's better to have two manifests there for user to choose the version they like to apply in their cluster.

@kubeflow-bot
Copy link

This change is Reviewable

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@PatrickXYS
Copy link
Member

/lgtm

@terrytangyuan
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c583951 into kubeflow:master Jun 26, 2020
@Jeffwan Jeffwan deleted the support_multi_version_manifest branch June 26, 2020 17:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants