-
Notifications
You must be signed in to change notification settings - Fork 34
Upgrade Golang version to 1.13.8 and Kubernetes version to 1.15.9 #53
Conversation
Travis tests have failedHey @Jeffwan, TravisBuddy Request Identifier: 5cd19220-5a60-11ea-af10-7fd2d08fe4df |
Tests are failed, can you please fix it? Thanks |
65cf97b
to
5125d55
Compare
Hey @Jeffwan, TravisCI finished with status TravisBuddy Request Identifier: 7ff7b510-5b21-11ea-b66e-89572c858fbd |
5125d55
to
bde75cc
Compare
Travis tests have failedHey @Jeffwan, TravisBuddy Request Identifier: f2e8fdc0-5b23-11ea-b66e-89572c858fbd |
@gaocegege go linter problem, current library has been deprecated. I file a separate PR #56 to address this issue and copyright header to fix CI. This PR will be updated later. |
bde75cc
to
285d850
Compare
Travis tests have failedHey @Jeffwan, TravisBuddy Request Identifier: f0503240-5d17-11ea-9390-21607e5de829 |
Travis tests have failedHey @Jeffwan, TravisBuddy Request Identifier: b4f03c70-5d19-11ea-9390-21607e5de829 |
Travis tests have failedHey @Jeffwan, TravisBuddy Request Identifier: 1da4f260-5d1f-11ea-9390-21607e5de829 |
004ac40
to
fd2dcdb
Compare
/cc @wackxu @gaocegege |
I have a follow up PR to delete |
/cc @gaocegege @wackxu kindly ping. :D |
Thanks for your contribution. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wackxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
`vendor` was from Godeps and has all build dependencies. `go build` ignore vendor directory by default and as we migrate to use go modules, there’s no need to keep `vendor` any more. This is a follow up PR of kubeflow#53 ./hack/update-codegen.sh has been upgrade to use code-generator under $GOPATH/pkg/mod Signed-off-by: Jiaxin Shan <[email protected]>
`vendor` was from Godeps and has all build dependencies. `go build` ignore vendor directory by default and as we migrate to use go modules, there’s no need to keep `vendor` any more. This is a follow up PR of #53 ./hack/update-codegen.sh has been upgrade to use code-generator under $GOPATH/pkg/mod Signed-off-by: Jiaxin Shan <[email protected]>
This change is