Skip to content
This repository has been archived by the owner on Feb 1, 2022. It is now read-only.

implementation of mxnet operator API v1 #39

Merged
merged 3 commits into from
May 28, 2019
Merged

Conversation

wackxu
Copy link
Contributor

@wackxu wackxu commented May 28, 2019

This is an exact copy of the v1beta1 APIs and controller implementation. Future API changes will be made to the v1 sub-folders.

ref #36

/assign @suleisl2000 @gaocegege


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @wackxu. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gaocegege
Copy link
Member

/ok-to-test

@wackxu
Thanks for your contribution! 🎉 👍

Can you split the commits? For example, we can put generated code (client-gen, defaulter-gen) in one commit then we can review the code that hand-written by you.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM
/lgtm

@gaocegege
Copy link
Member

Well I prefer adding e2e test for mxnet operator, too.

But it is not in the scope of this PR.

/cc @richardsliu

@TravisBuddy
Copy link

Travis tests have failed

Hey @wackxu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 6b710d00-8118-11e9-b9f1-63f75d62ea26

@wackxu
Copy link
Contributor Author

wackxu commented May 28, 2019

/ok-to-test

@wackxu
Thanks for your contribution!

Can you split the commits? For example, we can put generated code (client-gen, defaulter-gen) in one commit then we can review the code that hand-written by you.

Done

@wackxu
Copy link
Contributor Author

wackxu commented May 28, 2019

Well I prefer adding e2e test for mxnet operator, too.

But it is not in the scope of this PR.

/cc @richardsliu

Yes, we need add e2e test and we can do this in follow pr.

@TravisBuddy
Copy link

Travis tests have failed

Hey @wackxu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 36fbd3f0-8124-11e9-b9f1-63f75d62ea26

@wackxu
Copy link
Contributor Author

wackxu commented May 28, 2019

@gaocegege The CI is green now. I think we can merge it first. And for API changes or bug fix that cherry pick from tf-operator could be done in the follow PR.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gaocegege
Copy link
Member

@suleisl2000 Need your approval

@suleisl2000
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleisl2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6d35b39 into kubeflow:master May 28, 2019
@wackxu wackxu deleted the apiv1 branch May 28, 2019 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants