Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

[UI] Add lineage sections to Model Detail views #81

Open
prodonjs opened this issue Jul 1, 2019 · 7 comments · Fixed by #84
Open

[UI] Add lineage sections to Model Detail views #81

prodonjs opened this issue Jul 1, 2019 · 7 comments · Fixed by #84

Comments

@prodonjs
Copy link
Contributor

prodonjs commented Jul 1, 2019

/kind feature
/area front-end

Retrieve and display related Data Set and Evaluation metrics for Models.

Mocks

@prodonjs
Copy link
Contributor Author

prodonjs commented Jul 3, 2019

@zhenghuiwang Can you point me to any guidance or documentation on how we might be able to use the new events API methods you added in #53?

For example, using the data in https://kubeflow-v-n00.endpoints.zhenghui-kubeflow-2.cloud.goog:
/api/v1alpha1/artifact_types/kubeflow.org/alpha/model/artifacts/40 is the model in question.

/api/v1alpha1/events/artifacts/40 gives back

{
   "events":[
      {
         "artifact_id":"40",
         "execution_id":"12",
         "type":"OUTPUT",
         "milliseconds_since_epoch":"1562114383006"
      }
   ]
}

Then, using the execution_id from the returned event, /api/v1alpha1/events/executions/12 returns

{
   "events":[
      {
         "artifact_id":"39",
         "execution_id":"12",
         "type":"INPUT",
         "milliseconds_since_epoch":"1562114382971"
      },
      {
         "artifact_id":"40",
         "execution_id":"12",
         "type":"OUTPUT",
         "milliseconds_since_epoch":"1562114383006"
      },
      {
         "artifact_id":"41",
         "execution_id":"12",
         "type":"OUTPUT",
         "milliseconds_since_epoch":"1562114383042"
      }
   ]
}

Would we then need to go about determining the type of each artifact listed there and retrieving them individually or is there something I am missing?

@zhenghuiwang
Copy link
Contributor

You're right. It is a problem: the response doesn't have type info about the artifacts&executions hence you can't retrieve each individual artifact&execution.

Proposed fix: I will add response field artifacts: map from id to artifact, and field executions similarly.

@prodonjs
Copy link
Contributor Author

prodonjs commented Jul 8, 2019

blocked by #84

@zhenghuiwang
Copy link
Contributor

/reopen

PR#84 is merged and I've updated our dev KF cluster to master. You should see the artifact&execution map in the ListEvent response now.

@k8s-ci-robot
Copy link

@zhenghuiwang: Reopened this issue.

In response to this:

/reopen

PR#84 is merged and I've updated our dev KF cluster to master. You should see the artifact&execution map in the ListEvent response now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Jul 8, 2019
@jtfogarty
Copy link

jtfogarty commented Jan 14, 2020

/kind feature
/priority p2

@k8s-ci-robot
Copy link

@jtfogarty: The label(s) area/feature cannot be applied, because the repository doesn't have them

In response to this:

/area feature
/priority p2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants