Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed ray README.md #2885

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hansinikarunarathne
Copy link
Member

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I changed create namespace of ray cluster README.md

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

Signed-off-by: Hansini Karunarathne <[email protected]>
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign juliusvonkohout for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hansinikarunarathne
Copy link
Member Author

@juliusvonkohout I made the requested change.

@juliusvonkohout
Copy link
Member

Hello, I see the v1.7 branch mentioned in a lot of places. Please do a thorough check of the readme.

@hansinikarunarathne
Copy link
Member Author

Hello, I see the v1.7 branch mentioned in a lot of places. Please do a thorough check of the readme.

Can you explain it more? I can not understand what you mean

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Oct 2, 2024

For example there is

## Step 1: Install Kubeflow v1.7-branch

* Install all Kubeflow official components and all common services using [one command](https://github.com/kubeflow/manifests/tree/v1.7-branch#install-with-a-single-command).

and many more.

Sometimes it also talks about 1.9. I would rather go for the master branch in all places.

So just a general cleanup / renovation of the documentation.

@juliusvonkohout
Copy link
Member

juliusvonkohout commented Oct 11, 2024

Also https://github.com/kubeflow/manifests/blob/master/contrib/ray/kuberay-operator/base/kustomization.yaml should be updated to be a proper kustomization file as the other ones

I think the ordering is different from other kustomization files and it is missing

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization

@juliusvonkohout
Copy link
Member

To be continued after December 10 by @hansinikarunarathne

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants