-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed ray README.md #2885
base: master
Are you sure you want to change the base?
Changed ray README.md #2885
Conversation
Signed-off-by: Hansini Karunarathne <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@juliusvonkohout I made the requested change. |
Hello, I see the v1.7 branch mentioned in a lot of places. Please do a thorough check of the readme. |
Can you explain it more? I can not understand what you mean |
For example there is manifests/contrib/ray/README.md Line 38 in fd32075
manifests/contrib/ray/README.md Line 41 in fd32075
and many more. Sometimes it also talks about 1.9. I would rather go for the master branch in all places. So just a general cleanup / renovation of the documentation. |
Also https://github.com/kubeflow/manifests/blob/master/contrib/ray/kuberay-operator/base/kustomization.yaml should be updated to be a proper kustomization file as the other ones I think the ordering is different from other kustomization files and it is missing
|
To be continued after December 10 by @hansinikarunarathne |
Pull Request Template for Kubeflow manifests Issues
✏️ A brief description of the changes
✅ Contributor checklist
DCO
check)